From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 2/2] drivers/net: use device name from device
 structure
Date: Fri, 9 Jun 2017 15:16:19 +0100
Message-ID: <9bf63904-051c-ff85-b80a-c2b4ba5bca63@intel.com>
References: <20170526161141.4746-1-ferruh.yigit@intel.com>
 <20170526161141.4746-2-ferruh.yigit@intel.com> <1804015.XMfruEeC3U@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, "John W. Linville" <linville@tuxdriver.com>,
 Stephen Hurd <stephen.hurd@broadcom.com>,
 Ajit Khaparde <ajit.khaparde@broadcom.com>,
 Declan Doherty <declan.doherty@intel.com>,
 Helin Zhang <helin.zhang@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,
 Wenzhuo Lu <wenzhuo.lu@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Pascal Mazon <pascal.mazon@6wind.com>, Gaetan Rivet
 <gaetan.rivet@6wind.com>, Jan Blunck <jblunck@infradead.org>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id AAF6A2B92
 for <dev@dpdk.org>; Fri,  9 Jun 2017 16:16:24 +0200 (CEST)
In-Reply-To: <1804015.XMfruEeC3U@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/9/2017 2:52 PM, Thomas Monjalon wrote:
> 26/05/2017 18:11, Ferruh Yigit:
>> Device name resides in two different locations, in rte_device->name and
>> in ethernet device private data.
> 
> Yes would be nice to remove the name from rte_eth_dev_data.
> 
>> For now, the copy in the ethernet device private data is required for
>> multi process support, the name is the how secondary process finds about
>> primary process device.
> 
> Yes it is in rte_eth_dev_attach_secondary().
> This secondary process forces us to write ugly data structures.
> 
>> But for drivers there is no reason to use the copy in the ethernet
>> device private data.
> 
> Yes I agree.
> There are probably other places where we can avoid using this field.
> I see rte_eth_dev_get_name_by_port() and rte_eth_dev_get_port_by_name()
> using rte_eth_dev_data[port].name.

I will scan librte_ether for the cases private name usage can be
eliminated and will send a new version of the patch.

> 
>> This patch updates PMDs to use only rte_device->name.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>