From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA066C54FD0 for ; Wed, 22 Apr 2020 02:07:25 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 93EAF206D5 for ; Wed, 22 Apr 2020 02:07:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93EAF206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2BCB51D417; Wed, 22 Apr 2020 04:07:24 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 2C42C1D40B for ; Wed, 22 Apr 2020 04:07:21 +0200 (CEST) IronPort-SDR: YO7ilLnMg4czVdNP64BTs/GV8TM1n7XB17oaZ65Fj9Aolbs/ggqKnJPJnrlJIvulpI805MEffu 69gCGVaS4h0g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2020 19:07:21 -0700 IronPort-SDR: /1DFu3IqNXMfS99uzP4cSisfOxCI+/I5xPBMC+BoSzJLbSc34wywjw3gIrfpo7doACvNgKyOGC cMY9F55T17gQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,412,1580803200"; d="scan'208";a="258906793" Received: from rmenon-mobl.amr.corp.intel.com (HELO [10.251.1.78]) ([10.251.1.78]) by orsmga006.jf.intel.com with ESMTP; 21 Apr 2020 19:07:20 -0700 To: Dmitry Kozlyuk , "dev@dpdk.org" Cc: "Dmitry Malloy (MESHCHANINOV)" , Narcisa Ana Maria Vasile , Fady Bader , Tal Shnaiderman , Thomas Monjalon , "Burakov, Anatoly" , Harini Ramakrishnan , Omar Cardona , "Kadam, Pallavi" References: <20200410164342.1194634-1-dmitry.kozliuk@gmail.com> <20200414194426.1640704-1-dmitry.kozliuk@gmail.com> <20200414194426.1640704-7-dmitry.kozliuk@gmail.com> From: Ranjit Menon Message-ID: <9c5212ba-57be-7d21-9541-171f61f97f95@intel.com> Date: Tue, 21 Apr 2020 19:07:20 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200414194426.1640704-7-dmitry.kozliuk@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 06/10] eal: introduce memory management wrappers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/14/2020 12:44 PM, Dmitry Kozlyuk wrote: > diff --git a/lib/librte_eal/windows/eal_memory.c b/lib/librte_eal/windows/eal_memory.c > new file mode 100644 > index 000000000..5697187ce > --- /dev/null > +++ b/lib/librte_eal/windows/eal_memory.c > @@ -0,0 +1,437 @@ > + > + if ((flags & EAL_RESERVE_EXACT_ADDRESS) && (virt != requested_addr)) { > + if (!VirtualFree(virt, 0, MEM_RELEASE)) Microsoft documentation suggests that we use VirtualFreeEx() to free memory allocated by VirtualAlloc2(). VirtualFreeEx() would require the handle to the current process that was passed into VirtualAlloc2() There are 6 other such occurrences in this file. ranjit m.