From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2] ethdev: change vtune profiling approach
Date: Thu, 23 Aug 2018 10:35:34 +0100
Message-ID: <9c8b6e92-40e1-f769-248e-0cca0fbed15c@intel.com>
References: <1530623488-69056-1-git-send-email-ilia.kurakin@intel.com>
 <1532002902-25187-1-git-send-email-ilia.kurakin@intel.com>
 <FBA6DD83-6456-4F97-926D-A5FEBB381CA0@intel.com>
 <4a3974e2-6116-0855-44a6-1795d485fcbf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: DPDK <dev@dpdk.org>, "Richardson, Bruce" <bruce.richardson@intel.com>,
 "Khatko, Roman P" <roman.p.khatko@intel.com>
To: "Wiles, Keith" <keith.wiles@intel.com>,
 "Kurakin, Ilia" <ilia.kurakin@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 6EBFE293B
 for <dev@dpdk.org>; Thu, 23 Aug 2018 11:35:42 +0200 (CEST)
In-Reply-To: <4a3974e2-6116-0855-44a6-1795d485fcbf@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 8/22/2018 6:13 PM, Ferruh Yigit wrote:
> On 7/24/2018 2:17 PM, Wiles, Keith wrote:
>>
>>
>>> On Jul 19, 2018, at 7:21 AM, ilia.kurakin@intel.com wrote:
>>>
>>> From: Ilia Kurakin <ilia.kurakin@intel.com>
>>>
>>> The patch changes rx_burst profiling approach:
>>> 	1. VTune's instrumentation is removed
>>> 	2. empty hook callback for profiling is added
>>> This way all VTune-specific logic moves to the VTune side.
>>> Hook is enabled only when CONFIG_RTE_ETHDEV_PROFILE_WITH_VTUNE option
>>> is turned on. VTune uses this hook to attach to the polling cycle. It
>>> is not possible to attach to the rx_burst directly, as it is inline.
>>>
>>> Signed-off-by: Ilia Kurakin <ilia.kurakin@intel.com>
>>>
>>> ---
>>>
>>> -v2 change:
>>> 	fix coding style issue, re-merge
>>>
>>> config/common_base                    |   2 +-
>>> doc/guides/prog_guide/profile_app.rst |  34 ++---------
>>> lib/librte_ethdev/ethdev_profile.c    | 103 +++++-----------------------------
>>> lib/librte_ethdev/ethdev_profile.h    |   6 +-
>>> lib/librte_ethdev/rte_ethdev.c        |   4 +-
>>> 5 files changed, 25 insertions(+), 124 deletions(-)
>>>
>>
>> Looks good and a cleaner method.
>>
>> Acked-by: Keith Wiles <keith.wiles@intel.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.