From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 01/16] net/axgbe: add minimal dev init and
 uninit support
Date: Tue, 9 Jan 2018 20:17:11 +0000
Message-ID: <9c8d5f85-387f-7669-e703-26e416b429cc@intel.com>
References: <1512047472-118050-1-git-send-email-Ravi1.kumar@amd.com>
 <1515145938-97474-1-git-send-email-Ravi1.kumar@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
To: Ravi Kumar <Ravi1.kumar@amd.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 2F991325F
 for <dev@dpdk.org>; Tue,  9 Jan 2018 21:17:13 +0100 (CET)
In-Reply-To: <1515145938-97474-1-git-send-email-Ravi1.kumar@amd.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/5/2018 9:52 AM, Ravi Kumar wrote:
> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>

lgtm except below comments.

At least share build error needs a new version of the patch.
Can you able to complete licensing updates for next version?

<...>

> @@ -445,6 +445,12 @@ CONFIG_RTE_LIBRTE_AVP_DEBUG_DRIVER=y
>  CONFIG_RTE_LIBRTE_AVP_DEBUG_BUFFERS=n
>  
>  #
> +# Compile AMD PMD
> +#
> +CONFIG_RTE_LIBRTE_AXGBE_PMD=n

Why disabled by default?

> +CONFIG_RTE_LIBRTE_AXGBE_DEBUG_INIT=n

As far as I can see dynamic logging implemented, is this config option still
needed? If you will remove this please remember to clean up the documentation too.

<...>

> +include $(RTE_SDK)/mk/rte.vars.mk
> +
> +#
> +# library name
> +#
> +LIB = librte_pmd_axgbe.a
> +
> +CFLAGS += -O3
> +CFLAGS += $(WERROR_FLAGS)
> +
> +EXPORT_MAP := rte_pmd_axgbe_version.map
> +
> +LIBABIVER := 1
> +

Need to add dependent libraries [1] or causing a build error for shared library
build [2].


[1]
Something like:
 LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
 LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
 LDLIBS += -lrte_bus_pc


[2]
build error:
.../drivers/net/axgbe/axgbe_ethdev.c:(.text+0x16): undefined reference to
`rte_pci_register'

To enable shared build, update config file:
CONFIG_RTE_BUILD_SHARED_LIB=y

<...>