From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 1/6] net/enic: enable RQ first and then post Rx buffers Date: Wed, 9 May 2018 19:50:39 +0100 Message-ID: <9c99d611-9e9e-d089-5f5b-71e229bcc6ea@intel.com> References: <20180503193713.20622-1-johndale@cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Hyong Youb Kim To: John Daley Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id EB41F1B761 for ; Wed, 9 May 2018 20:50:42 +0200 (CEST) In-Reply-To: <20180503193713.20622-1-johndale@cisco.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/3/2018 8:37 PM, John Daley wrote: > From: Hyong Youb Kim > > Future VIC adapters may require that the driver enable RQ before > posting new buffers to the NIC. So split enic_alloc_rx_queue_mbufs() > into two functions, one that allocates buffers and fills RQ and the > other that posts them (i.e. PIO write to a doorbell). And, call the > post function only after enabling RQ. > > Currently released models are not affected by this change, as they > work fine whether the driver posts buffers before or after enabling RQ. > > Signed-off-by: Hyong Youb Kim > Reviewed-by: John Daley > Reviewed-by: Aaron Conole Series applied to dpdk-next-net/master, thanks.