From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v3] app/testpmd: fix testpmd failure due to RSS offload check Date: Wed, 25 Apr 2018 17:34:20 +0100 Message-ID: <9d79e68c-67c4-ed24-6a4b-747ddc33c751@intel.com> References: <20180425014929.72014-1-qi.z.zhang@intel.com> <20180425133816.198161-1-qi.z.zhang@intel.com> <20180425162705.GU4957@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: thomas@monjalon.net, dev@dpdk.org To: Adrien Mazarguil , Qi Zhang Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id B9FB3AABB for ; Wed, 25 Apr 2018 18:34:23 +0200 (CEST) In-Reply-To: <20180425162705.GU4957@6wind.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/25/2018 5:27 PM, Adrien Mazarguil wrote: > On Wed, Apr 25, 2018 at 09:38:16PM +0800, Qi Zhang wrote: >> After add RSS hash offload check, default rss_hf will fail on >> devices that not support all bits, the patch take rss_hf as >> a suggest value and only set bits that device supported base on >> rte_eth_dev_get_info, also rss_hf will only be updated when new >> rss offload is successfully updated on all ports by >> "port config all rss [!default]" command. >> >> Fixes: 586ac442be96 ("ethdev: add supported hash function check") >> Fixes: 8c1f4aff92a6 ("app/testpmd: new parameter for port config all RSS command") >> Signed-off-by: Qi Zhang > > Although this approach prevents updating rss_hf if at least one port doesn't > support RSS configuration (i.e. it can't be used to update defaults for > subsequent flow rules on mlx4), Yes it does, and perhaps we need a value per port, instead of single value for all. > I confirm it does fix the startup issue, > therefore: > > Tested-by: Adrien Mazarguil >