From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-stable] [PATCH v2] app/testpmd: fix quit to
 stop all ports before close
Date: Wed, 9 Jan 2019 12:26:36 +0000
Message-ID: <9de702ed-1481-ec4c-b840-7c85b4138bc7@intel.com>
References: <20190104122833.49245-1-cristian.dumitrescu@intel.com>
 <8CEF83825BEC744B83065625E567D7C260D4A3DD@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Wu, Jingjing"
 <jingjing.wu@intel.com>, "stable@dpdk.org" <stable@dpdk.org>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
 "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <8CEF83825BEC744B83065625E567D7C260D4A3DD@IRSMSX108.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/4/2019 1:47 PM, Iremonger, Bernard wrote:
>> -----Original Message-----
>> From: Dumitrescu, Cristian
>> Sent: Friday, January 4, 2019 12:29 PM
>> To: dev@dpdk.org
>> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
>> <jingjing.wu@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>;
>> stable@dpdk.org
>> Subject: [PATCH v2] app/testpmd: fix quit to stop all ports before close
>>
>> This patch proposes a slightly different test-pmd quit operation: stop all devices
>> before starting to close any device. Basically, stop all moving parts before
>> beginning to remove them. The current test-pmd quit is stopping and closing
>> each device before moving to the next device.
>>
>> If all devices in the system are independent of each other, this difference is
>> usually not important. In case of Soft NIC devices, any such virtual device
>> typically depends on one or more physical devices being alive, as it accesses
>> their queues, so this difference becomes important.
>>
>> Without this straightforward fix, all the Soft NIC devices need to be manually
>> stopped before the quit command is issued, otherwise the quit command can
>> sometimes crash the test-pmd application.
>>
>> Fixes: d3a274ce9dee ("app/testpmd: handle SIGINT and SIGTERM")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> 
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>

Applied to dpdk-next-net/master, thanks.