From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1832EC433ED for ; Mon, 19 Apr 2021 12:40:25 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 7B78E611CE for ; Mon, 19 Apr 2021 12:40:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B78E611CE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D2D4141283; Mon, 19 Apr 2021 14:40:23 +0200 (CEST) Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by mails.dpdk.org (Postfix) with ESMTP id 012544123B for ; Mon, 19 Apr 2021 14:40:21 +0200 (CEST) Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4FP5v94qRtz7vw2; Mon, 19 Apr 2021 20:37:57 +0800 (CST) Received: from [10.78.49.194] (10.78.49.194) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.498.0; Mon, 19 Apr 2021 20:40:15 +0800 To: "Li, Xiaoyun" , "Yigit, Ferruh" CC: "dev@dpdk.org" , "linuxarm@openeuler.org" References: <1614938252-62955-1-git-send-email-oulijun@huawei.com> <1618233177-50822-1-git-send-email-oulijun@huawei.com> From: oulijun Message-ID: <9efc877e-ab4a-2b1c-8423-daf714fbd323@huawei.com> Date: Mon, 19 Apr 2021 20:40:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.78.49.194] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH V3] app/testpmd: support Tx mbuf free on demand cmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" ÔÚ 2021/4/19 11:11, Li, Xiaoyun дµÀ: > Hi > >> -----Original Message----- >> From: Lijun Ou >> Sent: Monday, April 12, 2021 21:13 >> To: Yigit, Ferruh >> Cc: Li, Xiaoyun ; dev@dpdk.org; >> linuxarm@openeuler.org >> Subject: [PATCH V3] app/testpmd: support Tx mbuf free on demand cmd >> >> From: Chengwen Feng >> >> This patch support tx_done_cleanup command: >> tx_done_cleanup port (port_id) (queue_id) (free_cnt) >> >> Users must make sure there are no concurrent access to the same Tx queue (like >> rte_eth_tx_burst, rte_eth_dev_tx_queue_stop and so on) this command >> executed. >> >> Signed-off-by: Chengwen Feng >> Signed-off-by: Lijun Ou > > As I remember, last comments (from Ferruh and Aaron) suggest you to do this in an unit test not testpmd. > Hi, Xiaoyun Maybe it is. We've tested it in our local environment and he's OK.If I use the community's method of unit testing, I may have trouble doing unit testing. Would you consider someone else to help me? I've already sent V4 and reverted to V3 and used the latest queue state solution. >> --- >> V2->V3: >> - The command implementation is changed so that the queuestate does >> not depend on the command execution. >> >> V1->V2: >> - use Tx instead of TX >> - add note in doc >> --- >> app/test-pmd/cmdline.c | 85 +++++++++++++++++++++++++++++ >> doc/guides/rel_notes/release_21_05.rst | 2 + >> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 11 ++++ >> 3 files changed, 98 insertions(+) > >> + >> show config >> ~~~~~~~~~~~ >> >> -- >> 2.7.4 > > . >