From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v4] vhost: batch used descs chains write-back with packed ring Date: Fri, 21 Dec 2018 10:20:53 +0100 Message-ID: <9f30e6f1-d373-fac1-4662-cbeecec3b75f@redhat.com> References: <20181220164755.8509-1-maxime.coquelin@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: dev@dpdk.org, i.maximets@samsung.com, tiwei.bie@intel.com, zhihong.wang@intel.com, jfreiman@redhat.com, mst@redhat.com Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 914361BD76 for ; Fri, 21 Dec 2018 10:21:01 +0100 (CET) In-Reply-To: <20181220164755.8509-1-maxime.coquelin@redhat.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/20/18 5:47 PM, Maxime Coquelin wrote: > Instead of writing back descriptors chains in order, let's > write the first chain flags last in order to improve batching. > > Also, move the write barrier in logging cache sync, so that it > is done only when logging is enabled. It means there is now > one more barrier for split ring when logging is enabled. > > With Kernel's pktgen benchmark, ~3% performance gain is measured. > > Signed-off-by: Maxime Coquelin > --- > lib/librte_vhost/vhost.h | 2 ++ > lib/librte_vhost/virtio_net.c | 19 ++++++++++++++++--- > 2 files changed, 18 insertions(+), 3 deletions(-) Applied to dpdk-next-virtio Maxime