From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hemant Agrawal Subject: Re: [PATCH] Create kern folder for Linux kernel modules Date: Fri, 22 Dec 2017 21:55:40 +0530 Message-ID: <9f9841c6-dee4-99ec-5cab-0667ccddc04b@nxp.com> References: <1513922231-15554-1-git-send-email-hemant.agrawal@nxp.com> <4919393.KhUSbVM1LT@xps> <10030168.6hk24mNXSe@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Cc: "dev@dpdk.org" , "Yigit, Ferruh" To: "Wiles, Keith" , Thomas Monjalon Return-path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0078.outbound.protection.outlook.com [104.47.33.78]) by dpdk.org (Postfix) with ESMTP id AC5A41B406 for ; Fri, 22 Dec 2017 17:27:37 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/22/2017 8:21 PM, Wiles, Keith wrote: > > >> On Dec 22, 2017, at 8:17 AM, Thomas Monjalon wrote: >> >> 22/12/2017 14:59, Wiles, Keith: >>> >>>> On Dec 22, 2017, at 5:38 AM, Thomas Monjalon wrote: >>>> >>>> 22/12/2017 11:04, Hemant Agrawal: >>>>> On 12/22/2017 2:13 PM, Thomas Monjalon wrote: >>>>>> These modules are Linux modules, so they should be in the linuxapp dir. >>>>> >>>>> >>>>> This is a cleaner separation w.r.t userspace/kernel space code. >>>>> *kern* is a better placefolder for LKMs. >>>> >>>> I prefer "kernel" name. >>> >>> The name should be related to Linux in some way, like linux_kern or linux_kernel or linux_modules (this is the one I prefer) this way it make it clear which OS they are designed for. >> >> If such top-level directory is created, the BSD modules must be moved there too. >> That's why "kernel/" or "kernel/linux/" is appropriate. > > OK seems reasonable, what about kernel/{freebsd,Linux, …}/modules/(module-name e.g. kni, igb_uio, nic_uio, …) > > Kernel is misleading IMO, but I can live with it as long as we break down the different kernel related items. This is why I add modules in the path, as we could have other OSes like Windows with items that are not modules or VMs or containers… > > I can live with kernel/{freebsd, linux, …}/{igb_uio, kni, nic_uio, ..} but I would like to make sure it does not change in the future with adding windows. Your suggestion seems reasonable. I am not sure about windows. May be some working on DPDK-on-windows can comment > >> >>>>> Also eal is not getting overloaded. >>>>> >>>>> linuxapp is part of librte_eal. KNI is not related to EAL, but still >>>>> the kni kernel code is added to librte_eal under linuxapp. >>>> >>>> Yes it makes sense. >>>> >>>> More opinions/votes? >>>> >>>>>> There are also some kernel modules in the bsdapp directory. >>>>> >>>>> We can move them as well. >> > > Regards, > Keith >