Re: [PATCH] pipeline: fix build with sanitizers or debug options

[Thomas Monjalon <thomas@monjalon.net>]

> > Similar to commit 84f5ac9418ea ("pipeline: fix build with ASan").
> > 
> > Here we are again. Depending on options (like debug, or ASan, or UBSan),
> > compilation can fail because of dumb construct like CHECK(0, XXX).
> > Dumb, because such an expression macro expands as: if (0) return -XXX;
> > 
> > ../lib/pipeline/rte_swx_pipeline.c: In function ‘instr_movh_translate’:
> > ../lib/pipeline/rte_swx_pipeline.c:3461:1: error: control reaches end of
> > 	non-void function [-Werror=return-type]
> >  3461 | }
> >       | ^
> > 
> > Remove any such call when at the end of functions, using a regexp:
> > %s/CHECK(0, \(.*\))\(;\n}\)/return -\1\2/
> > 
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Fixes: 2f8168eac37a ("pipeline: add instruction for IPv6 address upper half")
Fixes: cdaa937d3eaa ("pipeline: support selector table")
Fixes: c6b752cdf215 ("pipeline: introduce SWX extern instruction")

Applied, thanks.


Should we remove the other instances of "CHECK(0," ?