From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wiles, Roger Keith" Subject: Re: [PATCH] rte_mempool_dump() crashes with NULL rte_mempool pointer. Date: Sun, 28 Sep 2014 01:10:10 +0000 Message-ID: References: <20140928003719.GA27849@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "" To: Neil Horman Return-path: In-Reply-To: <20140928003719.GA27849-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> Content-Language: en-US Content-ID: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" OK, let me look at RTE_VERIFY then and will send a new patch. On Sep 27, 2014, at 7:37 PM, Neil Horman wrote: > On Sat, Sep 27, 2014 at 06:35:01PM +0000, Wiles, Roger Keith wrote: >>=20 >> Check the FILE *f and rte_mempool *mp pointers for NULL and >> return plus print out a message if RTE_LIBRTE_MEMPOOL_DEBUG is enabled. >>=20 >> Signed-off-by: Keith Wiles >> --- >> lib/librte_mempool/rte_mempool.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >>=20 >> diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_m= empool.c >> index 332f469..efa6a6c 100644 >> --- a/lib/librte_mempool/rte_mempool.c >> +++ b/lib/librte_mempool/rte_mempool.c >> @@ -765,6 +765,12 @@ rte_mempool_dump(FILE *f, const struct rte_mempool = *mp) >> unsigned common_count; >> unsigned cache_count; >>=20 >> + if ( (f =3D=3D NULL) || (mp =3D=3D NULL) ) { >> +#ifdef RTE_LIBRTE_MEMPOOL_DEBUG >> + fprintf(stderr, "*** Called rte_mempool_dump(%p, %p) with NULL a= rgument\n", f, mp); >> +#endif /* RTE_LIBRTE_MEMPOOL_DEBUG */ >> + return; >> + } >> fprintf(f, "mempool <%s>@%p\n", mp->name, mp); >> fprintf(f, " flags=3D%x\n", mp->flags); >> fprintf(f, " ring=3D<%s>@%p\n", mp->ring->name, mp->ring); >> --=20 >> 2.1.0 >>=20 >>=20 > Maybe use RTE_VERIFY instead? > Neil >=20 Keith Wiles, Principal Technologist with CTO office, Wind River mobile 972-= 213-5533