From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH v2 08/16] Add support for mapping devices through VFIO. Date: Thu, 22 May 2014 12:06:53 +0000 Message-ID: References: <1400514709-24087-9-git-send-email-anatoly.burakov@intel.com> <6426409.afQ7rpamsg@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev-VfR2kkLFssw@public.gmane.org" To: Thomas Monjalon Return-path: In-Reply-To: <6426409.afQ7rpamsg@xps13> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Thomas, > How did you test this feature? > Did you see some performance differences with igb_uio? The same way everything else is tested - bind a NIC to the driver and see i= f it works :-) As for performance differences, potentially it can be degraded a bit becaus= e of mandatory IOMMU involvement, but I did not see any performance impact = during my tests. > For history reason, it's better to explain in another patch that eal_hpet= has > been renamed eal_timer and there is no such need anymore in this file. Agreed. >=20 > We should discuss a way to request igb_uio or VFIO binding of a device. Why? The device can either be bound to VFIO or igb_uio. So unless you want = binding code in DPDK EAL (to avoid which the pci_unbind/igb_uio_bind/dpdk_b= ind script was created in the first place), I see no point in that. The dpd= k_bind script already does that (you bind either to igb_uio or to vfio-pci)= . > This whole socket communication deserves a separated patch with protocol > description. Agreed, I'll break it up and provide a more detailed explanation. > By the way, I'm not a big fan of the suffix "_socket" which can be mislea= ding. > But I have no other good naming idea. Would _mp_socket do? =20 > So we have another thread to manage. > I don't see where it is spawned? In rte_eal_pci_init(). > You are defining some variables in a .h file. I think it is a problem. Well, they need to be shared between several .c files. =20 > Here are some other relevant errors from checkpatch.pl: Thanks, I'll fix those. Best regards, Anatoly Burakov DPDK SW Engineer