From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH v10 04/20] ethtool: update header doxygen
	syntax
Date: Thu, 6 Jul 2017 09:18:42 +0000
Message-ID: <C6ECDF3AB251BE4894318F4E4512369782257739@IRSMSX109.ger.corp.intel.com>
References: <20170630165140.59594-1-ferruh.yigit@intel.com>
 <20170704161337.45926-1-ferruh.yigit@intel.com>
 <20170704161337.45926-5-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: Stephen Hemminger <stephen@networkplumber.org>, "Richardson, Bruce"
 <bruce.richardson@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 02B1F2C8
 for <dev@dpdk.org>; Thu,  6 Jul 2017 11:18:46 +0200 (CEST)
In-Reply-To: <20170704161337.45926-5-ferruh.yigit@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> From: Yigit, Ferruh
> Sent: Tuesday, July 4, 2017 5:13 PM
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Stephen Hemminger
> <stephen@networkplumber.org>; Richardson, Bruce
> <bruce.richardson@intel.com>; Burakov, Anatoly
> <anatoly.burakov@intel.com>
> Subject: [PATCH v10 04/20] ethtool: update header doxygen syntax
>=20
> Minor corrections and doxygen syntax fixes on library header file.
>=20
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  lib/librte_ethtool/rte_ethtool.h | 57 +++++++++++++++++++++-------------=
--
> ----
>  1 file changed, 30 insertions(+), 27 deletions(-)
>=20
> diff --git a/lib/librte_ethtool/rte_ethtool.h b/lib/librte_ethtool/rte_et=
htool.h
> index 18f44404b..bcf20870c 100644
> --- a/lib/librte_ethtool/rte_ethtool.h
> +++ b/lib/librte_ethtool/rte_ethtool.h
> @@ -34,11 +34,13 @@
>  #ifndef _RTE_ETHTOOL_H_
>  #define _RTE_ETHTOOL_H_
>=20
> -/*
> +/**
> + * @file
> + *
>   * This new interface is designed to provide a user-space shim layer for
>   * Ethtool and Netdevice op API.
>   *
> - * rte_ethtool_get_driver:          ethtool_ops::get_driverinfo
> + * rte_ethtool_get_drvinfo:         ethtool_ops::get_driverinfo
>   * rte_ethtool_get_link:            ethtool_ops::get_link
>   * rte_ethtool_get_regs_len:        ethtool_ops::get_regs_len
>   * rte_ethtool_get_regs:            ethtool_ops::get_regs
> @@ -47,6 +49,8 @@
>   * rte_ethtool_set_eeprom:          ethtool_ops::set_eeprom
>   * rte_ethtool_get_pauseparam:      ethtool_ops::get_pauseparam
>   * rte_ethtool_set_pauseparam:      ethtool_ops::set_pauseparam
> + * rte_ethtool_get_ringparam:       ethtool_ops::set_ringparam
> + * rte_ethtool_set_ringparam:       ethtool_ops::set_ringparam

Typo? set_ringparam appears two times.