From: Praveen Kaligineedi <pkaligineedi@google.com>
To: stephen@networkplumber.org
Cc: Joshua Washington <joshwash@google.com>,
Jeroen de Borst <jeroendb@google.com>,
Rushil Gupta <rushilg@google.com>,
dev@dpdk.org, Ferruh Yigit <ferruh.yigit@amd.com>,
Praveen Kaligineedi <pkaligineei@google.com>
Subject: Re: [PATCH] net/gve: Allocate qpl pages using malloc if memzone allocation fails
Date: Thu, 19 Dec 2024 12:53:14 -0800 [thread overview]
Message-ID: <CA+f9V1Nq8ZywGuZ6+=22Om5A8f1BQom_bHf4FMyPuBneFCevMw@mail.gmail.com> (raw)
In-Reply-To: <20241218195140.60a1f58b@hermes.local>
The TX queue requires IOVA contiguous QPL memory. So, we still need
memzone code for TX queues.
Regards,
Praveen
On Wed, Dec 18, 2024 at 7:51 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Wed, 18 Dec 2024 15:46:35 -0800
> Joshua Washington <joshwash@google.com> wrote:
>
> > From: Praveen Kaligineedi <pkaligineedi@google.com>
> >
> > Allocating QPL for an RX queue might fail if enough contiguous IOVA
> > memory cannot be allocated. However, the only requirement for QPL
> > for RX is that each 4K buffer be IOVA contiguous, not the entire
> > QPL. Therefore, use malloc to allocate 4K buffers if the allocation
> > using memzone fails.
> >
> > Signed-off-by: Praveen Kaligineedi <pkaligineedi@google.com>
> > Reviewed-by: Joshua Washington <joshwash@google.com>
> > ---
>
> Why keep the memzone code? rte_malloc and memzone are both coming from
> huge pages. Is there any advantage to memzone for what you are doing?
>
> Better to not have two potential allocation paths to test.
next prev parent reply other threads:[~2024-12-23 10:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 23:46 [PATCH] net/gve: Allocate qpl pages using malloc if memzone allocation fails Joshua Washington
2024-12-19 3:51 ` Stephen Hemminger
2024-12-19 20:53 ` Praveen Kaligineedi [this message]
2024-12-19 22:34 ` Stephen Hemminger
2024-12-20 0:04 ` Stephen Hemminger
2024-12-23 20:16 ` [PATCH v2] " Joshua Washington
2025-01-07 19:02 ` [PATCH v3] net/gve: allocate RX QPL pages using malloc Joshua Washington
2025-01-09 19:46 ` [PATCH v4] " Joshua Washington
2025-01-09 20:05 ` Joshua Washington
2025-01-09 22:14 ` Stephen Hemminger
2025-01-30 18:42 ` Stephen Hemminger
-- strict thread matches above, loose matches on Subject: below --
2024-12-23 20:11 [PATCH] net/gve: Allocate qpl pages using malloc if memzone allocation fails Joshua Washington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+f9V1Nq8ZywGuZ6+=22Om5A8f1BQom_bHf4FMyPuBneFCevMw@mail.gmail.com' \
--to=pkaligineedi@google.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=jeroendb@google.com \
--cc=joshwash@google.com \
--cc=pkaligineei@google.com \
--cc=rushilg@google.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).