From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Subject: Question regarding mempool changes impact to XEN PMD
Date: Mon, 13 Jun 2016 09:34:51 +0200
Message-ID: <CAATJJ0+9SWu_Wht3ij58kmFwC5Poim-xJVaayJpJ0XeFDrtXFg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
To: David Marchand <david.marchand@6wind.com>, dev <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-qk0-f180.google.com (mail-qk0-f180.google.com
 [209.85.220.180]) by dpdk.org (Postfix) with ESMTP id 973D847CE
 for <dev@dpdk.org>; Mon, 13 Jun 2016 09:35:11 +0200 (CEST)
Received: by mail-qk0-f180.google.com with SMTP id p10so34674027qke.3
 for <dev@dpdk.org>; Mon, 13 Jun 2016 00:35:11 -0700 (PDT)
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi David,
it seems to be the first time I compiled with
CONFIG_RTE_LIBRTE_PMD_XENVIRT=3Dy sinec the bigger mempool changes around
"587d684d doc: update release notes about mempool allocation".

I've seen related patch to mempool / xen in that regard "c042ba20 mempool:
rework support of Xen dom0"

But with above config symbol enabled I got:
drivers/net/xenvirt/rte_xen_lib.c: In function =E2=80=98grant_gntalloc_mbuf=
_pool=E2=80=99:
drivers/net/xenvirt/rte_xen_lib.c:440:69: error: =E2=80=98struct rte_mempoo=
l=E2=80=99 has
no member named =E2=80=98elt_va_start=E2=80=99
  if (snprintf(val_str, sizeof(val_str), "%"PRIxPTR,
(uintptr_t)mpool->elt_va_start) =3D=3D -1)
                                                                     ^
  SYMLINK-FILE include/rte_eth_bond.h
mk/internal/rte.compile-pre.mk:126: recipe for target 'rte_xen_lib.o' faile=
d
make[4]: *** [rte_xen_lib.o] Error 1
make[4]: *** Waiting for unfinished jobs....

The change around the mempools is complex, so I don't see on the first look
if that needs a minor or major rework in the xen sources.
I mean I don't want it to compile, but to work and that could be more than
just fixing that changed structure :-)

So I wanted to ask if you as author would see if it is a trivial change
that has to be made?


Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd