From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Subject: Re: [PATCH] net/mlx4: Avoid stripping the glue library
Date: Tue, 31 Jul 2018 15:32:55 +0200
Message-ID: <CAATJJ0LC2mEDVe1O4KAsEmWS4vdj7nTwa1qNeA2+G-TEkNW9Xw@mail.gmail.com>
References: <99e701e9982397b2d3febb2f36309225481158e9.1533042801.git.tredaelli@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: matan@mellanox.com, Shahaf Shuler <shahafs@mellanox.com>,
 dev <dev@dpdk.org>, adrien.mazarguil@6wind.com
To: "Timothy M. Redaelli" <tredaelli@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from youngberry.canonical.com (youngberry.canonical.com
 [91.189.89.112]) by dpdk.org (Postfix) with ESMTP id 9C3E914E8
 for <dev@dpdk.org>; Tue, 31 Jul 2018 15:33:22 +0200 (CEST)
Received: from mail-oi0-f72.google.com ([209.85.218.72])
 by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.76) (envelope-from <christian.ehrhardt@canonical.com>)
 id 1fkUmA-0001KD-Co for dev@dpdk.org; Tue, 31 Jul 2018 13:33:22 +0000
Received: by mail-oi0-f72.google.com with SMTP id 20-v6so13765508ois.21
 for <dev@dpdk.org>; Tue, 31 Jul 2018 06:33:22 -0700 (PDT)
In-Reply-To: <99e701e9982397b2d3febb2f36309225481158e9.1533042801.git.tredaelli@redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jul 31, 2018 at 3:26 PM Timothy Redaelli <tredaelli@redhat.com>
wrote:

> Stripping binaries at build time is usually a bad thing since it makes
> impossible to generate (split) debug symbols and this can lead to a more
> difficult debugging.
>
> CC: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> Fixes: 27cea11686ff ("net/mlx4: spawn rdma-core dependency plug-in")
>
> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> ---
>  drivers/net/mlx4/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx4/Makefile b/drivers/net/mlx4/Makefile
> index 63bc00337..92e932250 100644
> --- a/drivers/net/mlx4/Makefile
> +++ b/drivers/net/mlx4/Makefile
> @@ -115,7 +115,7 @@ endif
>  $(LIB_GLUE): mlx4_glue.o
>         $Q $(LD) $(GLUE_LDFLAGS) $(EXTRA_LDFLAGS) \
>                 -Wl,-h,$(LIB_GLUE) \
> -               -s -shared -o $@ $< -libverbs -lmlx4
> +               -shared -o $@ $< -libverbs -lmlx4
>
>  mlx4_glue.o: mlx4_autoconf.h
>
>
After IRC discussion I completely agree that this shouldn't be stripped,
thanks for the fix.

Acked-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

--

2.17.1
>
>

-- 
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd