From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shweta Choudaha <shweta.choudaha@gmail.com>
Subject: Re: [PATCH v3] net/ixgbe: Add access and locking APIs
	for MDIO
Date: Fri, 13 Apr 2018 17:41:14 +0100
Message-ID: <CAActUdeSbD14g24e8GaPiUHO7qL7PtDXdaqom0did7hG222Mdg@mail.gmail.com>
References: <20180321173618.74200-2-shweta.choudaha@gmail.com>
 <20180411135935.61232-1-shweta.choudaha@gmail.com>
 <039ED4275CED7440929022BC67E70611531909EA@SHSMSX103.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "Zhang,
 Helin" <helin.zhang@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 "shweta.choudaha@att.com" <shweta.choudaha@att.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-vk0-f66.google.com (mail-vk0-f66.google.com
 [209.85.213.66]) by dpdk.org (Postfix) with ESMTP id 1CD621B1E0
 for <dev@dpdk.org>; Fri, 13 Apr 2018 18:41:14 +0200 (CEST)
Received: by mail-vk0-f66.google.com with SMTP id i75so936187vke.8
 for <dev@dpdk.org>; Fri, 13 Apr 2018 09:41:14 -0700 (PDT)
In-Reply-To: <039ED4275CED7440929022BC67E70611531909EA@SHSMSX103.ccr.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Qi,

   I have addressed your comments and sent a v4 patchset.

Thanks,
Shweta

On Fri, Apr 13, 2018 at 3:37 AM, Zhang, Qi Z <qi.z.zhang@intel.com> wrote:

> Hi Choudaha:
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shweta Choudaha
> > Sent: Wednesday, April 11, 2018 10:00 PM
> > To: dev@dpdk.org
> > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin
> > <konstantin.ananyev@intel.com>; Zhang, Helin <helin.zhang@intel.com>;
> Yigit,
> > Ferruh <ferruh.yigit@intel.com>; shweta.choudaha@att.com
> > Subject: [dpdk-dev] [PATCH v3] net/ixgbe: Add access and locking APIs for
> > MDIO
>
> Nitpick: title should not start with uppercase.
>
> > +
> > +EXPERIMENTAL {
> > +     global:
> > +
> > +     rte_pmd_ixgbe_lock_mdio;
> > +     rte_pmd_ixgbe_unlock_mdio;
>
> Can we rename to rte_pmd_ixgbe_mdio_lock and rte_pmd_ixgbe_mdio_unlock, so
> all mdio functions can be list closely when follow the alphabet sequence?
>
>
> > +     rte_pmd_ixgbe_mdio_read_unlocked;
> > +     rte_pmd_ixgbe_mdio_write_unlocked;
>
> And this could be rte_pmd_ixgbe_mdio_unlocked_read/write to follow the
> same pattern that action after object
>
> Regards
> Qi
>
> > +} DPDK_18.05;
> > --
> > 2.11.0
>
>