From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
Subject: Re: [PATCH] net/bnxt: add missing ids in xstats
Date: Thu, 7 Jun 2018 14:34:19 -0700
Message-ID: <CACZ4nhshUenSOeEcnuSQSbDgc2oyrAGGFDFxeiZfs0arqEmbaQ@mail.gmail.com>
References: <1528349765-31471-1-git-send-email-david.marchand@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, Somnath Kotur <somnath.kotur@broadcom.com>,
 dpdk stable <stable@dpdk.org>
To: David Marchand <david.marchand@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-ot0-f194.google.com (mail-ot0-f194.google.com
 [74.125.82.194]) by dpdk.org (Postfix) with ESMTP id 940D12F7D
 for <dev@dpdk.org>; Thu,  7 Jun 2018 23:35:00 +0200 (CEST)
Received: by mail-ot0-f194.google.com with SMTP id q1-v6so13279854oth.13
 for <dev@dpdk.org>; Thu, 07 Jun 2018 14:35:00 -0700 (PDT)
In-Reply-To: <1528349765-31471-1-git-send-email-david.marchand@6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Jun 6, 2018 at 10:36 PM, David Marchand <david.marchand@6wind.com>
wrote:

> The xstats api expects that the driver fills both values and ids for each
> filled entries.
>
> Fixes: bfb9c2260be2 ("net/bnxt: support xstats get/reset")
>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
>
=E2=80=8B=E2=80=8B
Acked-by:
=E2=80=8B Ajit Khaparde <ajit.khaparde@broadcom.com>
=E2=80=8B


> ---
>  drivers/net/bnxt/bnxt_stats.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.=
c
> index bbd4e78..a5d3c86 100644
> --- a/drivers/net/bnxt/bnxt_stats.c
> +++ b/drivers/net/bnxt/bnxt_stats.c
> @@ -278,6 +278,7 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_de=
v,
>         count =3D 0;
>         for (i =3D 0; i < RTE_DIM(bnxt_rx_stats_strings); i++) {
>                 uint64_t *rx_stats =3D (uint64_t *)bp->hw_rx_port_stats;
> +               xstats[count].id =3D count;
>                 xstats[count].value =3D rte_le_to_cpu_64(
>                                 *(uint64_t *)((char *)rx_stats +
>                                 bnxt_rx_stats_strings[i].offset));
> @@ -286,6 +287,7 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_de=
v,
>
>         for (i =3D 0; i < RTE_DIM(bnxt_tx_stats_strings); i++) {
>                 uint64_t *tx_stats =3D (uint64_t *)bp->hw_tx_port_stats;
> +               xstats[count].id =3D count;
>                 xstats[count].value =3D rte_le_to_cpu_64(
>                                  *(uint64_t *)((char *)tx_stats +
>                                 bnxt_tx_stats_strings[i].offset));
> @@ -293,6 +295,7 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_de=
v,
>         }
>
>         /* The Tx drop pkts aka the Anti spoof coounter */
> +       xstats[count].id =3D count;
>         xstats[count].value =3D rte_le_to_cpu_64(tx_drop_pkts);
>         count++;
>
> --
> 2.7.4
>
>