From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ajit Khaparde Subject: Re: [PATCH] net/bnxt: fix packet type Date: Tue, 6 Feb 2018 15:23:34 -0800 Message-ID: References: <20180206170758.1148-1-olivier.matz@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org, Somnath Kotur , dpdk stable To: Olivier Matz Return-path: Received: from mail-qk0-f195.google.com (mail-qk0-f195.google.com [209.85.220.195]) by dpdk.org (Postfix) with ESMTP id A5FE11B768 for ; Wed, 7 Feb 2018 00:24:15 +0100 (CET) Received: by mail-qk0-f195.google.com with SMTP id m130so4613671qke.1 for ; Tue, 06 Feb 2018 15:24:15 -0800 (PST) In-Reply-To: <20180206170758.1148-1-olivier.matz@6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Feb 6, 2018 at 9:07 AM, Olivier Matz wrote= : > The hw flags are not read correctly: the defines > RX_PKT_CMPL_FLAGS_ITYPE_* are not bits but values, so the should not be > tested with if (value & X) but with if ((value & MASK) =3D=3D X). > This was resulting in a wrong packet type. > > For instance, an IPv4/ICMP packet was returning a value of 7 for > the layer 4, which is undefined. > > This patch rework the way packet types are processed, to ensure > that only valid packet types will be advertised. > > Fixes: 3d2a6644eb05 ("net/bnxt: support getting ptypes") > Cc: stable@dpdk.org > > Signed-off-by: Olivier Matz > =E2=80=8BAcked-by: Ajit Khaparde =E2=80=8B > --- > drivers/net/bnxt/bnxt_rxr.c | 75 ++++++++++++++++++++++++++++-- > --------------- > 1 file changed, 47 insertions(+), 28 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c > index 9b88a64bf..2b4044a83 100644 > --- a/drivers/net/bnxt/bnxt_rxr.c > +++ b/drivers/net/bnxt/bnxt_rxr.c > @@ -338,41 +338,60 @@ static inline struct rte_mbuf *bnxt_tpa_end( > static uint32_t > bnxt_parse_pkt_type(struct rx_pkt_cmpl *rxcmp, struct rx_pkt_cmpl_hi > *rxcmp1) > { > - uint32_t pkt_type =3D 0; > - uint32_t t_ipcs =3D 0, ip =3D 0, ip6 =3D 0; > - uint32_t tcp =3D 0, udp =3D 0, icmp =3D 0; > - uint32_t vlan =3D 0; > + uint32_t l3, pkt_type =3D 0; > + uint32_t t_ipcs =3D 0, ip6 =3D 0, vlan =3D 0; > + uint32_t flags_type; > > vlan =3D !!(rxcmp1->flags2 & > rte_cpu_to_le_32(RX_PKT_CMPL_FLAGS2_META_FORMAT_VLAN)); > + pkt_type |=3D vlan ? RTE_PTYPE_L2_ETHER_VLAN : RTE_PTYPE_L2_ETHER= ; > + > t_ipcs =3D !!(rxcmp1->flags2 & > rte_cpu_to_le_32(RX_PKT_CMPL_FLAGS2_T_IP_CS_CALC)); > ip6 =3D !!(rxcmp1->flags2 & > rte_cpu_to_le_32(RX_PKT_CMPL_FLAGS2_IP_TYPE)); > - icmp =3D !!(rxcmp->flags_type & > - rte_cpu_to_le_16(RX_PKT_CMPL_FLAGS_ITYPE_ICMP)); > - tcp =3D !!(rxcmp->flags_type & > - rte_cpu_to_le_16(RX_PKT_CMPL_FLAGS_ITYPE_TCP)); > - udp =3D !!(rxcmp->flags_type & > - rte_cpu_to_le_16(RX_PKT_CMPL_FLAGS_ITYPE_UDP)); > - ip =3D !!(rxcmp->flags_type & > - rte_cpu_to_le_16(RX_PKT_CMPL_FLAGS_ITYPE_IP)); > - > - pkt_type |=3D ((ip || tcp || udp || icmp) && !t_ipcs && !ip6) ? > - RTE_PTYPE_L3_IPV4_EXT_UNKNOWN : 0; > - pkt_type |=3D ((ip || tcp || udp || icmp) && !t_ipcs && ip6) ? > - RTE_PTYPE_L3_IPV6_EXT_UNKNOWN : 0; > - pkt_type |=3D (!t_ipcs && icmp) ? RTE_PTYPE_L4_ICMP : 0; > - pkt_type |=3D (!t_ipcs && udp) ? RTE_PTYPE_L4_UDP : 0; > - pkt_type |=3D (!t_ipcs && tcp) ? RTE_PTYPE_L4_TCP : 0; > - pkt_type |=3D ((ip || tcp || udp || icmp) && t_ipcs && !ip6) ? > - RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN : 0; > - pkt_type |=3D ((ip || tcp || udp || icmp) && t_ipcs && ip6) ? > - RTE_PTYPE_INNER_L3_IPV6_EXT_UNKNOWN : 0; > - pkt_type |=3D (t_ipcs && icmp) ? RTE_PTYPE_INNER_L4_ICMP : 0; > - pkt_type |=3D (t_ipcs && udp) ? RTE_PTYPE_INNER_L4_UDP : 0; > - pkt_type |=3D (t_ipcs && tcp) ? RTE_PTYPE_INNER_L4_TCP : 0; > - pkt_type |=3D vlan ? RTE_PTYPE_L2_ETHER_VLAN : 0; > + > + flags_type =3D rxcmp->flags_type & > + rte_cpu_to_le_32(RX_PKT_CMPL_FLAGS_ITYPE_MASK); > + > + if (!t_ipcs && !ip6) > + l3 =3D RTE_PTYPE_L3_IPV4_EXT_UNKNOWN; > + else if (!t_ipcs && ip6) > + l3 =3D RTE_PTYPE_L3_IPV6_EXT_UNKNOWN; > + else if (t_ipcs && !ip6) > + l3 =3D RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN; > + else > + l3 =3D RTE_PTYPE_INNER_L3_IPV6_EXT_UNKNOWN; > + > + switch (flags_type) { > + case RTE_LE32(RX_PKT_CMPL_FLAGS_ITYPE_ICMP): > + if (!t_ipcs) > + pkt_type |=3D l3 | RTE_PTYPE_L4_ICMP; > + else > + pkt_type |=3D l3 | RTE_PTYPE_INNER_L4_ICMP; > + break; > + > + case RTE_LE32(RX_PKT_CMPL_FLAGS_ITYPE_TCP): > + if (!t_ipcs) > + pkt_type |=3D l3 | RTE_PTYPE_L4_TCP; > + else > + pkt_type |=3D l3 | RTE_PTYPE_INNER_L4_TCP; > + break; > + > + case RTE_LE32(RX_PKT_CMPL_FLAGS_ITYPE_UDP): > + if (!t_ipcs) > + pkt_type |=3D l3 | RTE_PTYPE_L4_UDP; > + else > + pkt_type |=3D l3 | RTE_PTYPE_INNER_L4_UDP; > + break; > + > + case RTE_LE32(RX_PKT_CMPL_FLAGS_ITYPE_IP): > + if (!t_ipcs) > + pkt_type |=3D l3 | RTE_PTYPE_L4_ICMP; > + else > + pkt_type |=3D l3 | RTE_PTYPE_INNER_L4_ICMP; > + break; > + } > > return pkt_type; > } > -- > 2.11.0 > >