From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
Subject: Re: [PATCH v2 20/25] bnxt: add support to get and clear
	VF specific stats
Date: Wed, 31 May 2017 09:27:30 -0500
Message-ID: <CACZ4nhuAS9bE=gmNsgqWvf8_BBvBsKy2FU3Z-_CQnc-LnxRWfA@mail.gmail.com>
References: <CACZ4nhuCdAoJJtmi2joaHf9+4+MzVFz87S-XO_J-HRBGUdiEFg@mail.gmail.com>
 <20170526183941.80678-1-ajit.khaparde@broadcom.com>
 <20170526183941.80678-21-ajit.khaparde@broadcom.com>
 <3d568535-8eda-d79f-bbe5-43f9f1071184@intel.com>
 <CACZ4nhuws4LUyOUr10i10gME+Xtz0UHYXfORAk7Lazuzux284A@mail.gmail.com>
 <759bde90-b1e2-1a69-f98e-a02e164608c8@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, Stephen Hurd <stephen.hurd@broadcom.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-qt0-f180.google.com (mail-qt0-f180.google.com
 [209.85.216.180]) by dpdk.org (Postfix) with ESMTP id E50F45699
 for <dev@dpdk.org>; Wed, 31 May 2017 16:28:11 +0200 (CEST)
Received: by mail-qt0-f180.google.com with SMTP id v27so13324675qtg.2
 for <dev@dpdk.org>; Wed, 31 May 2017 07:28:11 -0700 (PDT)
In-Reply-To: <759bde90-b1e2-1a69-f98e-a02e164608c8@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, May 31, 2017 at 4:57 AM, Ferruh Yigit <ferruh.yigit@intel.com>
wrote:

> On 5/31/2017 3:12 AM, Ajit Khaparde wrote:
> >
> > On Mon, May 29, 2017 at 12:43 PM, Ferruh Yigit <ferruh.yigit@intel.com
> > <mailto:ferruh.yigit@intel.com>> wrote:
> >
> >     > +int rte_pmd_bnxt_get_tx_drop_count(uint8_t port, uint64_t *count=
)
> >     > +{
> >     > +     struct rte_eth_dev *dev;
> >     > +     struct rte_eth_dev_info dev_info;
> >     > +     struct bnxt *bp;
> >     > +
> >     > +     dev =3D &rte_eth_devices[port];
> >     > +     rte_eth_dev_info_get(port, &dev_info);
> >     > +     bp =3D (struct bnxt *)dev->data->dev_private;
> >     > +
> >     > +     return bnxt_hwrm_func_qstats_tx_drop(bp, 0xffff, count);
> >     > +}
> >
> >     This function is not to get VF stats from PF. As far as I can see
> this
> >     just gets queue stats, does this really needs to be PMD specific AP=
I,
> >     isn't this something generic?
> >
> >
> > =E2=80=8BYes. That is right. It returns a count of number of packets wh=
ich were
> > not transmitted
> > because it did not pass the MAC/VLAN spoof check.
> > It does not
> > necessarily mean "failure to transmit" and so I don't think it is right
> > to map it to oerrors.
> > So in the current form I don't see a way to make a generic function out
> > of it.=E2=80=8B
>
> I see, this is implemented because there is no place in basic stats to
> put tx_drop_pkts.
>
> Can xstats be used to get this value? Can new .xstats_get_by_id help here=
?
>
=E2=80=8BMay be we could. Do we have time for that?=E2=80=8B