From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
Subject: Re: [PATCH v3 22/26] net/bnxt: add code to determine the
	Rx status of VF
Date: Thu, 1 Jun 2017 11:36:05 -0500
Message-ID: <CACZ4nhv9aM=FM75SKFiXL9rnJVT9ZUJhDb3jDdmKvcKjrh3dvw@mail.gmail.com>
References: <5d0e287f-dfe9-3a41-695e-9af0d57d37c1@intel.com>
 <20170601030232.38677-1-ajit.khaparde@broadcom.com>
 <20170601030232.38677-23-ajit.khaparde@broadcom.com>
 <5fac4171-de91-8953-2df3-b78b0708c439@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, Stephen Hurd <stephen.hurd@broadcom.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-qk0-f181.google.com (mail-qk0-f181.google.com
 [209.85.220.181]) by dpdk.org (Postfix) with ESMTP id 4F3F87CC4
 for <dev@dpdk.org>; Thu,  1 Jun 2017 18:36:46 +0200 (CEST)
Received: by mail-qk0-f181.google.com with SMTP id 19so40848086qke.2
 for <dev@dpdk.org>; Thu, 01 Jun 2017 09:36:46 -0700 (PDT)
In-Reply-To: <5fac4171-de91-8953-2df3-b78b0708c439@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jun 1, 2017 at 7:28 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote=
:

> Hi Ajit,
>
> On 6/1/2017 4:02 AM, Ajit Khaparde wrote:
> > This patch adds code to determine the Rx status of a VF.
> > It adds the rte_pmd_bnxt_get_vf_rx_status call, which calculates
> > the VNIC count of the function to get the Rx status.
> >
> > Signed-off-by: Stephen Hurd <stephen.hurd@broadcom.com>
> > Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>
> <...>
>
> > +int rte_pmd_bnxt_get_tx_drop_count(uint8_t port, uint64_t *count)
> > +{
> > +     struct rte_eth_dev *dev;
> > +     struct rte_eth_dev_info dev_info;
> > +     struct bnxt *bp;
> > +
> > +     dev =3D &rte_eth_devices[port];
> > +     if (!is_bnxt_supported(dev))
> > +             return -ENOTSUP;
> > +
> > +     rte_eth_dev_info_get(port, &dev_info);
> > +     bp =3D (struct bnxt *)dev->data->dev_private;
> > +
> > +     return bnxt_hwrm_func_qstats_tx_drop(bp, 0xffff, count);
> > +}
>
> I guess there is rebasing error here, this function left here and
> causing a build error [1].
> (or function tries to sneak in within another patch :)
>
=E2=80=8BYes. It seems to have. I was actually trying to avoid this and com=
pile
testing
at a minimum during each rebase step to make sure.
But may be the warning message scrolled away.

I am sending a new series.

Thanks
=E2=80=8B


>
> [1]
> .../drivers/net/bnxt/rte_pmd_bnxt.c:639:5: error: no previous prototype
> for function 'rte_pmd_bnxt_get_tx_drop_count'
> [-Werror,-Wmissing-prototypes]
> int rte_pmd_bnxt_get_tx_drop_count(uint8_t port, uint64_t *count)
>     ^
>