From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Boldin Subject: Re: [PATCH v4 1/5] vhost: eventfd_link: moving ioctl to a function Date: Thu, 7 May 2015 16:16:34 +0300 Message-ID: References: <1427123731-15654-1-git-send-email-pboldin@mirantis.com> <1427994080-10163-1-git-send-email-pboldin@mirantis.com> <1427994080-10163-2-git-send-email-pboldin@mirantis.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "dev-VfR2kkLFssw@public.gmane.org" To: "Xie, Huawei" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Thu, May 7, 2015 at 10:57 AM, Xie, Huawei wrote: > On 4/3/2015 1:02 AM, Pavel Boldin wrote: > > Move ioctl `EVENTFD_COPY' handler code to an inline function. > Pavel: > There is no necessity to inline this function. > Xie, there is even no necessity to split this in a five piece patchseries. I did that solely for the purpose of clean reading. There is no necessity to inline any single-used functions as long the compiler is decent. But I prefer to instruct compiler to do this explictly so there is no call/ret path in the generated code. Pavel > /huawei >