From: Pavel Boldin <pboldin-nYU0QVwCCFFWk0Htik3J/w@public.gmane.org>
To: Thomas Monjalon
<thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
Subject: Re: [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'
Date: Fri, 27 Mar 2015 14:36:46 +0200 [thread overview]
Message-ID: <CACf4_B9ims0bL3fqk5Pm6sTHkm7pdHcTgFNXLvKYZf5Gip9LDg@mail.gmail.com> (raw)
In-Reply-To: <15186425.TaoBqciV4t@xps13>
On Fri, Mar 27, 2015 at 1:10 PM, Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
wrote:
> > > Due to increased `struct file's reference counter subsequent call
> > > to `filp_close' does not free the `struct file'. Prepend `fput' call
> > > to decrease the reference counter.
> > >
> > > Signed-off-by: Pavel Boldin <pboldin-nYU0QVwCCFFWk0Htik3J/w@public.gmane.org>
> >
> > Acked-by Huawei Xie <huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> Applied, thanks
>
What should I do with the refactoring patch in your opinion?
Should I split it in parts to ease review?
Pavel
next prev parent reply other threads:[~2015-03-27 12:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 12:53 [PATCH] vhost: Fix `struct file' leakage in `eventfd_link' Pavel Boldin
2015-03-23 14:21 ` Xie, Huawei
[not found] ` <C37D651A908B024F974696C65296B57B0F3F1E14-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-03-23 14:36 ` Pavel Boldin
2015-03-23 14:41 ` Xie, Huawei
[not found] ` <C37D651A908B024F974696C65296B57B0F3F1F75-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-03-23 14:51 ` Pavel Boldin
2015-03-23 15:16 ` Xie, Huawei
[not found] ` <C37D651A908B024F974696C65296B57B0F3F240D-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-03-23 15:22 ` Thomas Monjalon
2015-03-23 15:27 ` Pavel Boldin
2015-03-23 15:36 ` Xie, Huawei
[not found] ` <C37D651A908B024F974696C65296B57B0F3F2694-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-03-23 15:44 ` Pavel Boldin
2015-03-24 6:28 ` Xie, Huawei
[not found] ` <C37D651A908B024F974696C65296B57B0F3F46FB-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-03-24 11:10 ` Pavel Boldin
2015-03-24 16:20 ` Xie, Huawei
[not found] ` <C37D651A908B024F974696C65296B57B0F3F59D7-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-03-24 20:08 ` Pavel Boldin
2015-03-26 7:53 ` Xie, Huawei
2015-03-27 11:12 ` Thomas Monjalon
2015-03-26 7:56 ` Xie, Huawei
[not found] ` <C37D651A908B024F974696C65296B57B0F3FB942-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-03-26 15:17 ` Pavel Boldin
2015-03-27 11:10 ` Thomas Monjalon
2015-03-27 12:36 ` Pavel Boldin [this message]
[not found] ` <CACf4_B9ims0bL3fqk5Pm6sTHkm7pdHcTgFNXLvKYZf5Gip9LDg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-27 13:15 ` Thomas Monjalon
2015-03-26 15:20 ` Xie, Huawei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACf4_B9ims0bL3fqk5Pm6sTHkm7pdHcTgFNXLvKYZf5Gip9LDg@mail.gmail.com \
--to=pboldin-nyu0qvwccffwk0htik3j/w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).