From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alejandro Lucero <alejandro.lucero@netronome.com>
Subject: Re: [PATCH 2/7] mem: use proper prefix
Date: Thu, 1 Nov 2018 16:18:08 +0000
Message-ID: <CAD+H990xaJvpo85eVLYuAeUaPy0RzkaSyYa1LDCNhiJRP5Vz2A@mail.gmail.com>
References: <20181031172931.11894-1-alejandro.lucero@netronome.com>
 <20181031172931.11894-3-alejandro.lucero@netronome.com>
 <68244b83-2810-043e-f9b5-0b8984e99ab9@intel.com>
 <1764123.29vNcfR2yM@xps> <c53430d3-53a5-bec4-87c7-dff17c849ddf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com
 [209.85.208.66]) by dpdk.org (Postfix) with ESMTP id 41C46B62
 for <dev@dpdk.org>; Thu,  1 Nov 2018 17:18:18 +0100 (CET)
Received: by mail-ed1-f66.google.com with SMTP id f8-v6so4647817edt.13
 for <dev@dpdk.org>; Thu, 01 Nov 2018 09:18:18 -0700 (PDT)
In-Reply-To: <c53430d3-53a5-bec4-87c7-dff17c849ddf@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Nov 1, 2018 at 3:03 PM Burakov, Anatoly <anatoly.burakov@intel.com>
wrote:

> On 01-Nov-18 2:50 PM, Thomas Monjalon wrote:
> > 01/11/2018 11:08, Burakov, Anatoly:
> >> On 31-Oct-18 5:29 PM, Alejandro Lucero wrote:
> >>> Current name rte_eal_check_dma_mask does not follow the naming
> >>> used in the rest of the file.
> >>>
> >>> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> >>> ---
> >>
> >> I don't think this belongs in the _mem_ namespace. It is usually used
> >> for things to do with memory, while the DMA mask IMO sits firmly in the
> >> domain of EAL, specifically bus subsystem.
> >
> > It is a memory allocation check, isn't it?
> >
> > I think rte_mem_ prefix is more meaningful.
> > Anyway, we should avoid rte_eal which is too vague.
> > For device management, we use rte_bus, rte_dev, etc.
> >
>
> No strong feelings here, you can keep the mem namespace. Dem alphabets
> tho...
>
>
Sure. I'll send the next version later today.
Thanks



> --
> Thanks,
> Anatoly
>