From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alejandro Lucero Subject: Re: [PATCH 0/5] net/nfp logging fixes Date: Thu, 26 Apr 2018 19:14:24 +0100 Message-ID: References: <20180425154551.6795-1-stephen@networkplumber.org> <20180426084253.1a615c82@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: dev To: Stephen Hemminger Return-path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 0A56B6CCC for ; Thu, 26 Apr 2018 20:14:25 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id w195so14550416wmw.2 for ; Thu, 26 Apr 2018 11:14:24 -0700 (PDT) In-Reply-To: <20180426084253.1a615c82@xeon-e3> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 26, 2018 at 4:42 PM, Stephen Hemminger < stephen@networkplumber.org> wrote: > On Thu, 26 Apr 2018 13:52:53 +0100 > Alejandro Lucero wrote: > > > Hi Stephen, > > > > Thanks for this patch set. > > > > I'm happy with it although I have some concerns regarding how the dynamic > > logs work, or maybe I have a wrong understanding about it. I have tried > to > > read some doc about how it works, and I found the original patch from > > Olivier the best source, so maybe things have changed a bit and my > concerns > > are unfounded. > > > > I think it is OK to specifically add something like > > > > --log-level='pmd\.i40e.*,8' > > > > if you want to debug a PMD, but if you are an user and you just want to > > know why the app is not finding any port, finding out the right string is > > not trivial. For example, with an PF, the NFP PMD goes through a process > > where the NFP device (no the NIC) is accessed first through a complex > > interface, then firmware is uploaded, DPDK ports created (for multiport > > devices), etc. I think any error in that process should be output if the > > right loglevel is there and not just if the right log type was > specifically > > enabled. Is this what would happen with your patchset? > > Most drivers set default log level to NOTICE. Then if they see something > obviously wrong it will show up if the right log level is used. > For the case of finding out why no drivers are found then doing > something like > --log-level='pmd.*:info' > would be useful. > > Latest version makes regex optional and allows symbolic levels. > > > > I have suffered silent configuration problems, like the NFP card being in > > the wrong NUMA socket, and although I can solve that quickly because I > have > > the knowledge, other people using NFP with DPDK require someone to help > > because they do not know what is going on. And this is usually bad > because > > they have another NIC card in the same host (in the right NUMA socket) > and > > the app just works smoothly then, leaving our NIC with a bad press. So I > > think, some errors should always appear with the right loglevel > configured. > > Driver should definitely use level > INFO for things that are wrong. > > Uhmm, yes. I think I need to submit some changes to the level of most of the PMD messages. Thanks for the heads up. I have reviewed and tested the patches and they all seem all right. Acked-by: Alejandro Lucero Tested-by: Alejandro Lucero