From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alejandro Lucero <alejandro.lucero@netronome.com>
Subject: Re: [PATCH] net/nfp: fix possible resource leak
Date: Tue, 17 Apr 2018 10:07:16 +0100
Message-ID: <CAD+H991xemg04yAoWQOUw2kThA46YoSVnMB1g-ESSWJonNEWxQ@mail.gmail.com>
References: <1523944748-13334-1-git-send-email-zhouyates@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: dev <dev@dpdk.org>
To: Yangchao Zhou <zhouyates@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com
 [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id 51ACB8DED
 for <dev@dpdk.org>; Tue, 17 Apr 2018 11:07:17 +0200 (CEST)
Received: by mail-wr0-f196.google.com with SMTP id d19so33331850wre.1
 for <dev@dpdk.org>; Tue, 17 Apr 2018 02:07:17 -0700 (PDT)
In-Reply-To: <1523944748-13334-1-git-send-email-zhouyates@gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Acked-by: Alejandro Lucero <alejandro.lucero@netronome.com>

On Tue, Apr 17, 2018 at 6:59 AM, Yangchao Zhou <zhouyates@gmail.com> wrote:

> Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
> ---
>  drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> index ad6ce72..f2fcc4a 100644
> --- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> +++ b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> @@ -816,6 +816,7 @@ struct nfp6000_area_priv {
>
>         if (fscanf(fp, "0x%lx 0x%lx 0x%lx", &start, &end, &flags) == 0) {
>                 printf("error reading resource file for bar size\n");
> +               fclose(fp);
>                 return -1;
>         }
>
> --
> 1.7.1
>
>