From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alejandro Lucero <alejandro.lucero@netronome.com>
Subject: Re: [PATCH] ethdev: check number of queues less than
	RTE_ETHDEV_QUEUE_STAT_CNTRS
Date: Fri, 11 Nov 2016 09:32:55 +0000
Message-ID: <CAD+H9924VgQ=mqp3dGoJBpZFY_u3gkCv7C8xh4gib8j25JS-vQ@mail.gmail.com>
References: <1478786449-44745-1-git-send-email-alejandro.lucero@netronome.com>
 <CAD+H990smsF169DngzuEAzSScDqqmkPJrnjB_U19hfc=bSpEew@mail.gmail.com>
 <CAD+H992Uafy1JtjEKSxDmV8FK6Qm9ahiB_bof1A=4MGZqb0d6w@mail.gmail.com>
 <1630834.YGmmObtqnA@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: dev <dev@dpdk.org>, Bert van Leeuwen <bert.vanleeuwen@netronome.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-vk0-f47.google.com (mail-vk0-f47.google.com
 [209.85.213.47]) by dpdk.org (Postfix) with ESMTP id 446585688
 for <dev@dpdk.org>; Fri, 11 Nov 2016 10:32:57 +0100 (CET)
Received: by mail-vk0-f47.google.com with SMTP id 137so9161161vkl.0
 for <dev@dpdk.org>; Fri, 11 Nov 2016 01:32:57 -0800 (PST)
In-Reply-To: <1630834.YGmmObtqnA@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Nov 11, 2016 at 9:29 AM, Thomas Monjalon <thomas.monjalon@6wind.com>
wrote:

> 2016-11-11 09:16, Alejandro Lucero:
> > Thomas,
> >
> > We are wondering if you realize this patch fixes a bug with current
> ethdev
> > code as a device can have more than RTE_ETHDEV_QUEUE_STAT_CNTRS.
> >
> > Maybe the commit message is giving the wrong impression and as you
> > commented, it should just focus on the bug it fixes and to leave for
> > another email thread the discussion of how to solve the
> > RTE_ETHDEV_QUEUE_STAT_CNTRS
> > problem.
> >
> > Should we remove this from patchwork and to send another patch that way?
>
> Yes please. It was my first comment, we don't understand the exact issue
> you are fixing.
>

OK


> And I have a bad feeling it could break something else (really just a
> feeling).
> It is not the kind of patch we can apply the last day of a release.
> That's why I think it should wait 17.02.
>
>
Fine.


> Of course you can try to convince me and others to apply it as a last
> minute
> patch. But why are you sending a patch on the generic API in the last days?
>
>
We just found it a couple of days ago.


> Last argument: it is not fixing a regression of 16.11, so it is not so
> urgent.
>