From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alejandro Lucero <alejandro.lucero@netronome.com>
Subject: Re: [PATCH v2 05/18] drivers/net/nfp/nfpcore: fix
	strncpy misuse
Date: Wed, 9 May 2018 10:49:29 +0100
Message-ID: <CAD+H9939oDL6AkcX2Ud+KDGmUDnwfvQ0SWTO-VBRLqbw-p4rig@mail.gmail.com>
References: <152582834896.6809.14521072557832633661.stgit@localhost.localdomain>
 <152582947587.6809.10453223101431457646.stgit@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: dev <dev@dpdk.org>
To: Andy Green <andy@warmcat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66])
 by dpdk.org (Postfix) with ESMTP id 0C288AAF3
 for <dev@dpdk.org>; Wed,  9 May 2018 11:49:30 +0200 (CEST)
Received: by mail-wm0-f66.google.com with SMTP id f8-v6so26562536wmc.4
 for <dev@dpdk.org>; Wed, 09 May 2018 02:49:30 -0700 (PDT)
In-Reply-To: <152582947587.6809.10453223101431457646.stgit@localhost.localdomain>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, May 9, 2018 at 2:31 AM, Andy Green <andy@warmcat.com> wrote:

> Signed-off-by: Andy Green <andy@warmcat.com>
> ---
>  drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> index 4e6c66624..52b294888 100644
> --- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> +++ b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> @@ -31,6 +31,8 @@
>  #include <sys/file.h>
>  #include <sys/stat.h>
>
> +#include <rte_string_fns.h>
> +
>  #include "nfp_cpp.h"
>  #include "nfp_target.h"
>  #include "nfp6000/nfp6000.h"
> @@ -846,7 +848,7 @@ nfp6000_init(struct nfp_cpp *cpp, const char *devname)
>
>
>         memset(desc->busdev, 0, BUSDEV_SZ);
> -       strncpy(desc->busdev, devname, strlen(devname));
> +       strlcpy(desc->busdev, devname, sizeof(desc->busdev));
>
>         ret = nfp_acquire_process_lock(desc);
>         if (ret)
>
>
Acked-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Tested-by: Alejandro Lucero <alejandro.lucero@netronome.com>