From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jay Rolette <rolette@infiniteio.com>
Subject: Re: [PATCH 2/3] rte_ctrl_if: add control interface
	library
Date: Thu, 28 Jan 2016 07:24:51 -0600
Message-ID: <CADNuJVqLWLpkdLpKfogttQOpJJJP2P_iX9iF59RYcCATuGSLWg@mail.gmail.com>
References: <1453911849-16562-1-git-send-email-ferruh.yigit@intel.com>
 <1453911849-16562-3-git-send-email-ferruh.yigit@intel.com>
 <56A9F827.1060403@intel.com>
 <20160128131500.GA16492@sivlogin002.ir.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
To: Remy Horton <remy.horton@intel.com>, DPDK <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-vk0-f41.google.com (mail-vk0-f41.google.com
 [209.85.213.41]) by dpdk.org (Postfix) with ESMTP id B8E8FC45A
 for <dev@dpdk.org>; Thu, 28 Jan 2016 14:24:51 +0100 (CET)
Received: by mail-vk0-f41.google.com with SMTP id e185so23377591vkb.1
 for <dev@dpdk.org>; Thu, 28 Jan 2016 05:24:51 -0800 (PST)
In-Reply-To: <20160128131500.GA16492@sivlogin002.ir.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jan 28, 2016 at 7:15 AM, Ferruh Yigit <ferruh.yigit@intel.com>
wrote:

> On Thu, Jan 28, 2016 at 11:14:47AM +0000, Remy Horton wrote:
> > On 27/01/2016 16:24, Ferruh Yigit wrote:
> >
> > > +   default:
> > > +           ret = -95 /* EOPNOTSUPP */;
> > > +           break;
> >
> > Is this intentional? -EOPNOTSUPP is -122 (-95 is -ENOTSOCK)..
> >
> Return value is not significant, callee just checks for negative value,
> I can remove comment to prevent confusion.
>

No, please fix the return value. Return values are significant when you are
trying to debug or understand the intent of the code.

Jay