From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jay Rolette Subject: Re: [PATCH] doc: announce KNI ethtool removal Date: Thu, 21 Jul 2016 13:20:23 -0500 Message-ID: References: <1469030873-5966-1-git-send-email-thomas.monjalon@6wind.com> <5790EB36.3000604@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Thomas Monjalon , DPDK To: Ferruh Yigit Return-path: Received: from mail-vk0-f53.google.com (mail-vk0-f53.google.com [209.85.213.53]) by dpdk.org (Postfix) with ESMTP id 1014C58D4 for ; Thu, 21 Jul 2016 20:20:24 +0200 (CEST) Received: by mail-vk0-f53.google.com with SMTP id s189so124956543vkh.1 for ; Thu, 21 Jul 2016 11:20:24 -0700 (PDT) In-Reply-To: <5790EB36.3000604@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 21, 2016 at 10:33 AM, Ferruh Yigit wrote: > On 7/20/2016 5:07 PM, Thomas Monjalon wrote: > > The out-of-tree kernel code must be avoided. > > Moreover there is no good reason to keep this legacy feature > > which is only partially supported. > > > > As described earlier in this plan: > > http://dpdk.org/ml/archives/dev/2016-July/043606.html > > it will help to keep PCI ids in PMD code. > > > > Signed-off-by: Thomas Monjalon > > --- > > doc/guides/rel_notes/deprecation.rst | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > > index f502f86..9cadf6a 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -41,3 +41,10 @@ Deprecation Notices > > * The mempool functions for single/multi producer/consumer are > deprecated and > > will be removed in 16.11. > > It is replaced by rte_mempool_generic_get/put functions. > > + > > +* The ethtool support will be removed from KNI in 16.11. > > + It is implemented only for igb and ixgbe. > > + It is really hard to maintain because it requires some out-of-tree > kernel > > + code to be duplicated in this kernel module. > > + Removing this partial support will help to restrict the PCI id > definitions > > + to the PMD code. > > > > KNI ethtool is functional and maintained, and it may have users! > > Why just removing it, specially without providing an alternative? > Is is good time to discuss KCP again? > Yes, my product uses it. Seems like we are back to the same discussion we had a few months ago about the KNI situation... It shouldn't be removed unless there is a replacement, ideally one that works with the normal Linux tools like every other network device. While the code wasn't ready at the time, it was a definite improvement over what we have with KNI today. Jay