From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jay Rolette <rolette@infinite.io>
Subject: Re: [PATCH 2/2] config: disable KNI ethtool by default
Date: Tue, 17 Jan 2017 12:44:48 -0600
Message-ID: <CADNuJVrYGN8e6W1J-WCJXxiaA6F6xiXp-LDH+9wbS9RqomGhDQ@mail.gmail.com>
References: <20170117180147.11247-1-ferruh.yigit@intel.com>
 <20170117180147.11247-2-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: DPDK <dev@dpdk.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-ua0-f177.google.com (mail-ua0-f177.google.com
 [209.85.217.177]) by dpdk.org (Postfix) with ESMTP id 53A8E11DE
 for <dev@dpdk.org>; Tue, 17 Jan 2017 19:44:49 +0100 (CET)
Received: by mail-ua0-f177.google.com with SMTP id 35so109532493uak.1
 for <dev@dpdk.org>; Tue, 17 Jan 2017 10:44:49 -0800 (PST)
In-Reply-To: <20170117180147.11247-2-ferruh.yigit@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jan 17, 2017 at 12:01 PM, Ferruh Yigit <ferruh.yigit@intel.com>
wrote:

> KNI ethtool support (KNI control path) is not commonly used,
> and it tends to break the build with new version of the Linux kernel.
>
> KNI ethtool feature is disabled by default. KNI datapath is not effected
> from this update.
>
> It is possible to enable feature explicitly with config option:
> "CONFIG_RTE_KNI_KMOD_ETHTOOL=y"
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>

Is there a test case somewhere to detect when it gets broken or is the
intent to let it bit-rot unless someone enables that option and
subsequently discovers it broken?

I know we don't do this for every config option, but given the fact that
this tends to get broken frequently, it seems riskier.

Jay


> ---
>  config/common_linuxapp | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/config/common_linuxapp b/config/common_linuxapp
> index d4c4f0c..2483dfa 100644
> --- a/config/common_linuxapp
> +++ b/config/common_linuxapp
> @@ -38,7 +38,6 @@ CONFIG_RTE_EXEC_ENV_LINUXAPP=y
>  CONFIG_RTE_EAL_IGB_UIO=y
>  CONFIG_RTE_EAL_VFIO=y
>  CONFIG_RTE_KNI_KMOD=y
> -CONFIG_RTE_KNI_KMOD_ETHTOOL=y
>  CONFIG_RTE_LIBRTE_KNI=y
>  CONFIG_RTE_LIBRTE_VHOST=y
>  CONFIG_RTE_LIBRTE_PMD_VHOST=y
> --
> 2.9.3
>
>