From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ariel Rodriguez <arodriguez-Ze/REwZ+V9sqDJ6do+/SaQ@public.gmane.org>
Subject: SEGMENTATION FAULT in kni example : kni_free_kni() call
Date: Tue, 28 Oct 2014 23:07:35 -0300
Message-ID: <CADoa0bbog5n7gsPU7013Jp8d584dCh_pT+w+pxCVtWMjnLkOGA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
To: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi, im trying the kni example. When i hit ctrl-c in the terminal  stopping
the example, the os signals  with a segmentation fault.

The issue is in this block of code:

static int kni_free_kni(uint8_t port_id) {
uint8_t i;
struct kni_port_params **p = kni_port_params_array;

if (port_id >= RTE_MAX_ETHPORTS || !p[port_id])
return -1;

-- for (i = 0; i < p[i]->nb_kni; i++) {
-- rte_kni_release(p[i]->kni[i]);
-- p[i]->kni[i] = NULL;
}
rte_eth_dev_stop(port_id);

return 0;
}


The following change fix that issue:

static int kni_free_kni(uint8_t port_id) {
uint8_t i;
struct kni_port_params **p = kni_port_params_array;

if (port_id >= RTE_MAX_ETHPORTS || !p[port_id])
return -1;

++ for (i = 0; i < p[port_id]->nb_kni; i++) {
++ rte_kni_release(p[port_id]->kni[i]);
++ p[port_id]->kni[i] = NULL;
}
rte_eth_dev_stop(port_id);

return 0;
}

Sorry for the basic of my fix ... i dont know  the correct style to report
this kind of issues... im just a user of the dpdk library ... but i meet
this bug ...


Regards.

Ariel Horacio Rodriguez.