From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Ryzhov Subject: Re: [PATCH v2] kni: use kni_ethtool_ops only with unknown drivers Date: Mon, 3 Dec 2018 17:06:05 +0300 Message-ID: References: <20181130192946.13732-1-iryzhov@nfware.com> <20181130194750.13870-1-iryzhov@nfware.com> <20181130153815.3be2f30b@xeon-e3> <7f929055-b55a-e839-9927-96787db88094@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Stephen Hemminger , dev@dpdk.org To: Ferruh Yigit Return-path: Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id C17EA1B3A6 for ; Mon, 3 Dec 2018 15:06:17 +0100 (CET) Received: by mail-pg1-f194.google.com with SMTP id d72so5758441pga.9 for ; Mon, 03 Dec 2018 06:06:17 -0800 (PST) In-Reply-To: <7f929055-b55a-e839-9927-96787db88094@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ferruh, What about the patch? I also support dropping ethtool for ixgbe and i40e, but to save generic ethtool_ops with .get_link implementation, because it's an essential function that works correctly after proper implementation of carrier status that was merged into 18.11. Also, other ethtool operations may be implemented in a driver-independent way using the same concept as for netdev_ops. On Mon, Dec 3, 2018 at 4:09 PM Ferruh Yigit wrote: > On 11/30/2018 11:38 PM, Stephen Hemminger wrote: > > On Fri, 30 Nov 2018 22:47:50 +0300 > > Igor Ryzhov wrote: > > > >> Current implementation of kni_ethtool_ops just uses corresponding > >> ethtool_ops function of underlying driver for all functions except for > >> .get_link. This commit sets kni->net_dev->ethtool_ops directly to the > >> ethtool_ops of the corresponding driver. > >> > >> For unknown drivers (all but ixgbe and i40e) we still use > >> kni_ethtool_ops with implemented .get_link function. > >> > >> Signed-off-by: Igor Ryzhov > > > > Why does KNI still support ethtool which: > > 1. Only works on a subset of devices > > 2. Requires a 3rd implmentation of the HW device (Linux, DPDK, and KNI) > > +1 to drop ethtool support, last time we tried concern was anybody may be > using > it, perhaps we can try again. > > > > > Then again why does KNI exist at all? What is missing from virtio user > which > > is faster anyway. > > > >