From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ravi Kerur <rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: Q on Support for I217 and I218 Intel chipsets.
Date: Mon, 5 Jan 2015 08:40:08 -0800
Message-ID: <CAFb4SLAvUiiDHuevRK5Qk_GYCii7LqfOAr+ADw9ezxdEcq_QRg@mail.gmail.com>
References: <CAFb4SLBH4SJ2kL-JeCziXMtiG-g+F3b6wQ__6fSjsTWq7LzO3A@mail.gmail.com>
 <1475634.GuJD5gSMru@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
To: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1475634.GuJD5gSMru@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Inline <rk>

On Mon, Jan 5, 2015 at 12:55 AM, Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
wrote:

> 2015-01-04 15:28, Ravi Kerur:
> > We have a Gigabyte H97N motherboard which has I217 Intel chipset which
> uses
> > e100e drivers. I looked into lib/librte_pmd_e1000 directory and I do see
> > that e1000e code is integrated but missing some support for read/write
> from
> > flash_address and other minor things. I have made changes shown below and
> > have done some testing with testpmd utility and now have following
> questions
> >
> > 1. What amount of testing is required to qualify patch as successfully
> > tested on new chipsets
>
> There is no good answer to this question. Generally, you must be sure that
> you don't break anything.
> So you must test the code paths you have changed.
>

<rk> yes I have done testing on Ubuntu for I217 using testpmd.

>
> > 2. FreeBSD testing, currently we have Ubuntu 14.04 installed on existing
> > H97N motherboard and testing is done solely on Linux. We plan to get
> > another motherboard which will have I218 chipset and still deciding
> whether
> > to go with FreeBSD or Ubuntu. So the question I have is what amount of
> > testing should be done on FreeBSD? I don't think
> setup.sh/dpdk_nic_bind.py
> > works on FreeBSD yet hence the question on testing.
>
> FreeBSD testing is required when patching common EAL, scripts or makefiles.
>
> > >  lib/librte_pmd_e1000/e1000/e1000_api.c          | 21
> +++++++++++++++++++++
> > >  lib/librte_pmd_e1000/e1000/e1000_api.h          |  1 +
> > >  lib/librte_pmd_e1000/e1000/e1000_osdep.h        | 24
> +++++++++++++++++++-----
>
> These files are part of the base driver.
> The rule is to not patch them and try to do the changes in PMD only.
> There can be exceptions if an Intel maintainer acknowledges it.
>

<rk>  Changes in these files are modifying existing macros

E1000_READ_FLASH_REG,
E1000_WRITE_FLASH_REG
...

If it is not recommended to modify these files, should I move macros into
some PMD file?

Thanks.

>
> --
> Thomas
>