From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ravi Kerur <rkerur@gmail.com>
Subject: Re: [PATCH v1] doc: Merge l3fwd and l3fwd-acl
 documentation files
Date: Mon, 8 May 2017 14:04:41 -0700
Message-ID: <CAFb4SLB2LdssxprPYXZAhDcm9SXYAJq5PU-E1WcPzczw3yfJfA@mail.gmail.com>
References: <1493145557-17160-1-git-send-email-rkerur@gmail.com>
 <2449201.3f6kNIuhA3@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Ananyev,
 Konstantin" <konstantin.ananyev@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg0-f66.google.com (mail-pg0-f66.google.com [74.125.83.66])
 by dpdk.org (Postfix) with ESMTP id 46747F72
 for <dev@dpdk.org>; Mon,  8 May 2017 23:04:42 +0200 (CEST)
Received: by mail-pg0-f66.google.com with SMTP id s62so12225242pgc.0
 for <dev@dpdk.org>; Mon, 08 May 2017 14:04:42 -0700 (PDT)
In-Reply-To: <2449201.3f6kNIuhA3@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sun, May 7, 2017 at 1:50 PM, Thomas Monjalon <thomas@monjalon.net> wrote:

> Hi,
>
> 25/04/2017 20:39, Ravi Kerur:
> > Merge relevant contents of l3fwd and l3fwd-acl documentation.
> > Modify l3fwd document with ACL specific information.
> > Remove l3fwd-acl documentation file.
> >
> > Signed-off-by: Ravi Kerur <rkerur@gmail.com>
> > ---
> >  doc/guides/sample_app_ug/img/ipv4_hash_rule.svg    | 158 +++++++++
> >  doc/guides/sample_app_ug/img/ipv4_lpm_rule.svg     | 139 ++++++++
> >  doc/guides/sample_app_ug/index.rst                 |   1 -
> >  doc/guides/sample_app_ug/l3_forward.rst            | 326
> ++++++++++++++++-
> >  .../sample_app_ug/l3_forward_access_ctrl.rst       | 385
> ---------------------
> >  5 files changed, 614 insertions(+), 395 deletions(-)
> >  create mode 100644 doc/guides/sample_app_ug/img/ipv4_hash_rule.svg
> >  create mode 100644 doc/guides/sample_app_ug/img/ipv4_lpm_rule.svg
> >  delete mode 100644 doc/guides/sample_app_ug/l3_forward_access_ctrl.rst
>
> I've not looked at the content.
> I just do not understand why a patch for merging content is adding
> some new files.
> Moreover, these SVG files contains some binary PNG.
> Please send only some source files.
>

Thanks John and Thomas for review.

We have created two new ".svg" files illustrating an example for LPM and
Exact Match rules and hence they are reflected in the patch.
I have created .svg files directly from inkscape and they now contain only
html.

I have sent 'v2', please review it and let me know if additional changes
are required.