From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ravi Kerur <rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v5 6/8] Move common functions in eal_pci.c
Date: Thu, 16 Apr 2015 15:12:57 -0700
Message-ID: <CAFb4SLBy-y-q9xFGZfQKVGmDFSU8BEh_ZJsqZySh9g_n4sj8nA@mail.gmail.com>
References: <1428608301-31033-1-git-send-email-rkerur@gmail.com>
 <1428608412-31191-1-git-send-email-rkerur@gmail.com>
 <1428608412-31191-7-git-send-email-rkerur@gmail.com>
 <1432996.oUgD5RRFGj@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
To: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1432996.oUgD5RRFGj@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

On Thu, Apr 16, 2015 at 2:02 AM, Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
wrote:

> This patch is very sensible and difficult to follow.
> I'm really afraid that some nasty bugs could be hidden.
> Please could you try to split it in several steps?
> Thanks
>

Sure, will drop eal_pci_uio.c and eal_pci_vfio.c  changes and will send out
new version.

>
> 2015-04-09 12:40, Ravi Kerur:
> > Changes in v5
> > Rebase to latest code.
> > Removed RTE_EXEC_ENV_BSDAPP from earlier changes.
> >
> > Changes in v4
> > Move common functions in eal_pci.c to librte_eal/common/
> > eal_common_pci.c file.
> >
> > Following functions are moved to eal_common_pci.c file.
> >
> > void *pci_map_resource(void *requested_addr, const int vfio_fd,
> >       const char *devname, off_t offset, size_t size);
> > int pci_addr_comparison(struct rte_pci_addr *addr,
> >                         struct rte_pci_addr *addr2);
> > int rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr,
> >                         struct rte_pci_device *dev);
> >
> > Use RTE_EXEC_ENV_BSDAPP to differentiate minor differences in
> > common function.
> > Fix checkpatch warnings and errors.
> >
> > Changes in v3
> > N/A
> >
> > Changes in v2
> > N/A
> >
> > Changes in v1
> > N/A
> >
> > Signed-off-by: Ravi Kerur <rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > ---
> >  lib/librte_eal/bsdapp/eal/eal_pci.c        | 122
> ++++-----------------------
> >  lib/librte_eal/common/eal_common_pci.c     | 130
> ++++++++++++++++++++++++++++-
> >  lib/librte_eal/common/eal_private.h        |  48 +++++++++++
> >  lib/librte_eal/linuxapp/eal/eal_pci.c      | 100 +---------------------
> >  lib/librte_eal/linuxapp/eal/eal_pci_init.h |   6 --
> >  lib/librte_eal/linuxapp/eal/eal_pci_uio.c  |  36 ++------
> >  lib/librte_eal/linuxapp/eal/eal_pci_vfio.c |  17 ++--
> >  7 files changed, 212 insertions(+), 247 deletions(-)
>
>