From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ravi Kerur <rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v5 2/8] Move common functions in eal.c
Date: Thu, 16 Apr 2015 15:08:49 -0700
Message-ID: <CAFb4SLCt6HAnL7tb7HJB2HBvHPoMghkv-e-pCiK_EyjYB_p9ew@mail.gmail.com>
References: <1428608301-31033-1-git-send-email-rkerur@gmail.com>
 <1428608412-31191-1-git-send-email-rkerur@gmail.com>
 <1428608412-31191-3-git-send-email-rkerur@gmail.com>
 <4780798.Fhdhc6hoDZ@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
To: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <4780798.Fhdhc6hoDZ@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

On Thu, Apr 16, 2015 at 1:24 AM, Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
wrote:

> Hi Ravi,
>
> I think this patch is too complex and move too many different things:
> - sysfs
> - mem_cfg
> - proc_type
> - application_usage
> Please split them up.
>
> I'm not sure the classification in eal_common_runtime.c and
> eal_common_system.c
> new file is clear.
>

I chose most system related functions (hugepages, lcore sockets, sysfs)
into eal_common_system.c file. Rest I moved them to eal_common_runtime.c
file for lack of better name. You want more fine grained control and divide
them into 4 files??

>
> 2015-04-09 12:40, Ravi Kerur:
> > +     mem_config = (struct rte_mem_config *) mmap(NULL,
> sizeof(*mem_config),
>
> Why this cast is needed?
>

Linux has it, BSD doesn't. I just chose Linux version.