From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chas Williams <3chas3@gmail.com>
Subject: Re: [PATCH 13/22] net/bonding: enable port detach on
 secondary process
Date: Thu, 7 Jun 2018 10:21:45 -0400
Message-ID: <CAG2-GkkVaxrFMteCMRiAkmQKGDoUwz0K99Up3Hvfe7mYd62Pcw@mail.gmail.com>
References: <20180607123849.14439-1-qi.z.zhang@intel.com>
 <20180607123849.14439-14-qi.z.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Thomas Monjalon <thomas@monjalon.net>, "Burakov,
 Anatoly" <anatoly.burakov@intel.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, dev@dpdk.org,
 Bruce Richardson <bruce.richardson@intel.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>,
 benjamin.h.shelton@intel.com, narender.vangati@intel.com
To: Qi Zhang <qi.z.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-io0-f193.google.com (mail-io0-f193.google.com
 [209.85.223.193]) by dpdk.org (Postfix) with ESMTP id BCCE21B023
 for <dev@dpdk.org>; Thu,  7 Jun 2018 16:21:46 +0200 (CEST)
Received: by mail-io0-f193.google.com with SMTP id t6-v6so12001964iob.10
 for <dev@dpdk.org>; Thu, 07 Jun 2018 07:21:46 -0700 (PDT)
In-Reply-To: <20180607123849.14439-14-qi.z.zhang@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jun 7, 2018 at 8:38 AM, Qi Zhang <qi.z.zhang@intel.com> wrote:

> Previously, detach port on secondary process will mess primary
> process and cause same device can't be attached again, by take
> advantage of rte_eth_release_port_local, we can support this with
> minor change.
>

This commit message needs some work.  Otherwise, I think this particular
patch is fine.


>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
>  drivers/net/bonding/rte_eth_bond_pmd.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
> b/drivers/net/bonding/rte_eth_bond_pmd.c
> index 02d94b1b1..1221f62b2 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -3065,6 +3065,7 @@ bond_probe(struct rte_vdev_device *dev)
>                 }
>                 /* TODO: request info from primary to set up Rx and Tx */
>                 eth_dev->dev_ops = &default_dev_ops;
> +               eth_dev->device = &dev->device;
>                 rte_eth_dev_probing_finish(eth_dev);
>                 return 0;
>         }
> @@ -3171,6 +3172,16 @@ bond_remove(struct rte_vdev_device *dev)
>         if (eth_dev == NULL)
>                 return -ENODEV;
>
> +       if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
> +               /* detach device on local pprocess only */
>

process?


> +               if (strlen(rte_vdev_device_args(dev)) == 0)
> +                       return rte_eth_dev_release_port_local(eth_dev);
> +               /**
> +                * else this is a private device for current process
> +                * so continue with normal detach scenario
> +                */
> +       }
> +
>         RTE_ASSERT(eth_dev->device == &dev->device);
>
>         internals = eth_dev->data->dev_private;
> --
> 2.13.6
>
>