From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chas Williams <3chas3@gmail.com> Subject: Re: [PATCH] net/bonding: fix invalid port id error Date: Thu, 19 Jul 2018 13:45:20 -0400 Message-ID: References: <1531912321-19544-1-git-send-email-radu.nicolau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: dev@dpdk.org, Declan Doherty , Chas Williams , Thomas Monjalon , stable@dpdk.org To: Radu Nicolau Return-path: In-Reply-To: <1531912321-19544-1-git-send-email-radu.nicolau@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This seems fine. The bond PMD seems to call back into itself early. On Wed, Jul 18, 2018 at 7:19 AM Radu Nicolau wrote: > setting up the bonding options before calling rte_eth_dev_probing_finish > triggers an invalid port id error because of port state not set, or set > unused > > Fixes: fbe90cdd776c ("ethdev: add probing finish function") > Cc: stable@dpdk.org > > Signed-off-by: Radu Nicolau > Signed-off-by: Chas Williams > --- > drivers/net/bonding/rte_eth_bond_pmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c > b/drivers/net/bonding/rte_eth_bond_pmd.c > index fc4d4fd..1320cfd 100644 > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > @@ -3238,6 +3238,7 @@ bond_probe(struct rte_vdev_device *dev) > internals = rte_eth_devices[port_id].data->dev_private; > internals->kvlist = kvlist; > > + rte_eth_dev_probing_finish(&rte_eth_devices[port_id]); > > if (rte_kvargs_count(kvlist, PMD_BOND_AGG_MODE_KVARG) == 1) { > if (rte_kvargs_process(kvlist, > @@ -3257,7 +3258,6 @@ bond_probe(struct rte_vdev_device *dev) > rte_eth_bond_8023ad_agg_selection_set(port_id, AGG_STABLE); > } > > - rte_eth_dev_probing_finish(&rte_eth_devices[port_id]); > RTE_BOND_LOG(INFO, "Create bonded device %s on port %d in mode %u > on " > "socket %u.", name, port_id, bonding_mode, > socket_id); > return 0; > -- > 2.7.5 > >