From mboxrd@z Thu Jan  1 00:00:00 1970
From: "santhosh K.S" <santhoshachar08@gmail.com>
Subject: Re: Accessing "device_id" from "rte_pci_device"
Date: Wed, 25 Jul 2018 15:58:20 +0530
Message-ID: <CAHJickZVQDd1ODkhLcqi3sxjSaqoiVk0SHbw3LOo0RxdFGSHSA@mail.gmail.com>
References: <CAHJickZAooHhYASeZM5naa0ixAUb6U3JuiwpaL+YaWS4=UsgUg@mail.gmail.com>
 <9B0331B6EBBD0E4684FBFAEDA55776F9673376EC@HASMSX110.ger.corp.intel.com>
 <CAHJickaT+gCoJ_O=jjwfyr8Hnm3PF60zt7fWpfChOm6p0yvhjg@mail.gmail.com>
 <CAHJickYNGDAe=pNBhdqNykns0NUD6k0xjTvjTx0sKQLVaVnWyA@mail.gmail.com>
 <9B0331B6EBBD0E4684FBFAEDA55776F967337C28@HASMSX110.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: rami.rosen@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com
 [209.85.208.48]) by dpdk.org (Postfix) with ESMTP id 6FC8B1C01
 for <dev@dpdk.org>; Wed, 25 Jul 2018 12:28:32 +0200 (CEST)
Received: by mail-ed1-f48.google.com with SMTP id k15-v6so6772082edr.3
 for <dev@dpdk.org>; Wed, 25 Jul 2018 03:28:32 -0700 (PDT)
In-Reply-To: <9B0331B6EBBD0E4684FBFAEDA55776F967337C28@HASMSX110.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi  Rami Rosen, et al,

Thanks for the response. Yes I can see in the code that rte_device struct
is part of rte_eth_dev_info. I tried to apply the patch you pointed o
<http://patchwork.dpdk.org/patch/37654/>n 17.11.3. But it failed at many
places. We don't want to migrate to 18.05 as it is not a stable release.
I've been asked to migrate to a stable version only. I also noticed from
the release note
<https://doc.dpdk.org/guides-18.05/rel_notes/release_18_05.html> that
*rte_ctrlmbuf_init()
API *is deprecated in 18.05. Which results in breaking our code, which
means more re-work; which we are trying our best to avoid at this point in
time. Hence We are not interested in migrating to 18.05. Can you please
suggest a safer alternative patch, which I can use to get around this
problem?

Best Regards,
Santhosh K S

On Wed, Jul 25, 2018 at 12:11 PM Rosen, Rami <rami.rosen@intel.com> wrote:

> Hi Santhos.
>
>
>
> >There is no member named "*device*" in "*rte_eth_dev_info*" struct. I
> looked at both 17.11 API documentation
> <http://doc.dpdk.org/api-17.11/structrte__eth__dev__info.html> and 18.05
> API documentation
> <http://doc.dpdk.org/api-18.05/structrte__eth__dev__info.html>.
>
>
>
> This is not accurate. There is no =E2=80=9Cdevice=E2=80=9D in rte_eth_dev=
_info
>
> In 17.11, but there is a =E2=80=9Cdevice=E2=80=9D in rte_eth_dev_info
>
>   in 18.05  (this is exactly what Ferru pathc did)
>
> See for example:
>
> http://doc.dpdk.org/api-18.05/rte__ethdev_8h_source.html
>
>
>
> and look for the first member of rte_eth_dev_info:
>
>
>
> truct rte_eth_dev_info
> <http://doc.dpdk.org/api-18.05/structrte__eth__dev__info.html> {
>
> 1055  struct rte_device
> <http://doc.dpdk.org/api-18.05/structrte__device.html> *device;
>
>
>
> (Or download 18.05 and look in the header file)
>
>
>
> It seems that the 18.05 API documentation
> <http://doc.dpdk.org/api-18.05/structrte__eth__dev__info.html> is not
> complete,
>
> should be fixed.
>
>
>
> Regards,
>
> Rami Rosen
>
> Intel Corporation
>
>
>