From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Marchand <david.marchand@redhat.com>
Subject: Re: [PATCH v1] devtools: fix error propagation from
	check-forbidden-tokens.awk
Date: Tue, 18 Dec 2018 15:27:47 +0100
Message-ID: <CAJFAV8w9cqsauY3hgZDzTQnU2NADtPD0JSf+QFZUtfzwzsBoYg@mail.gmail.com>
References: <1545141782-31841-1-git-send-email-arnon@qwilt.com>
 <CAJFAV8ybiKKeNioBJMCa6O=JY=MJEy5JgZ-gjs_4hxq7yk0ZCw@mail.gmail.com>
 <CAJFAV8xAZq8-yvvBhuNXxyPLZGR4u2hmcwT3X_HwEceH3Xsp=g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>, ajit.khaparde@broadcom.com,
 thomasm@mellanox.com, dev@dpdk.org
To: Arnon Warshavsky <arnon@qwilt.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com
 [209.85.217.53]) by dpdk.org (Postfix) with ESMTP id F25071BB20
 for <dev@dpdk.org>; Tue, 18 Dec 2018 15:28:00 +0100 (CET)
Received: by mail-vs1-f53.google.com with SMTP id x1so10075651vsc.10
 for <dev@dpdk.org>; Tue, 18 Dec 2018 06:28:00 -0800 (PST)
In-Reply-To: <CAJFAV8xAZq8-yvvBhuNXxyPLZGR4u2hmcwT3X_HwEceH3Xsp=g@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Dec 18, 2018 at 3:16 PM David Marchand <david.marchand@redhat.com>
wrote:

>
>
> On Tue, Dec 18, 2018 at 3:12 PM David Marchand <david.marchand@redhat.com>
> wrote:
>
>>
>>
>> On Tue, Dec 18, 2018 at 3:03 PM Arnon Warshavsky <arnon@qwilt.com> wrote:
>>
>>> Bugzilla ID: 165
>>> Fixes: 4d4c612e6a30 ("devtools: check wrong svg include in guides")
>>> Signed-off-by: Arnon Warshavsky <arnon@qwilt.com>
>>>
>>> Explicitly collect the output and result of the
>>> multiple awk script calls, print and return error
>>> if any of them fails
>>> ---
>>>  devtools/checkpatches.sh | 21 +++++++++++++++++----
>>>  1 file changed, 17 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
>>> index ee8debe..df4336c 100755
>>> --- a/devtools/checkpatches.sh
>>> +++ b/devtools/checkpatches.sh
>>> @@ -44,22 +44,35 @@ print_usage () {
>>>  }
>>>
>>>  check_forbidden_additions() { # <patch>
>>> +       res=0
>>> +
>>>         # refrain from new additions of rte_panic() and rte_exit()
>>>         # multiple folders and expressions are separated by spaces
>>> -       awk -v FOLDERS="lib drivers" \
>>> +       result=$(awk -v FOLDERS="lib drivers" \
>>>                 -v EXPRESSIONS="rte_panic\\\( rte_exit\\\(" \
>>>                 -v RET_ON_FAIL=1 \
>>>                 -v MESSAGE='Using rte_panic/rte_exit' \
>>>                 -f $(dirname $(readlink -e
>>> $0))/check-forbidden-tokens.awk \
>>> -               "$1"
>>> +               "$1")
>>> +       if [ $? -ne 0 ] ; then
>>> +               echo $result
>>> +               res=1
>>> +       fi
>>> +
>>>         # svg figures must be included with wildcard extension
>>>         # because of png conversion for pdf docs
>>> -       awk -v FOLDERS='doc' \
>>> +       result=$(awk -v FOLDERS='doc' \
>>>                 -v EXPRESSIONS='::[[:space:]]*[^[:space:]]*\\.svg' \
>>>                 -v RET_ON_FAIL=1 \
>>>                 -v MESSAGE='Using explicit .svg extension instead of .*'
>>> \
>>>                 -f $(dirname $(readlink -e
>>> $0))/check-forbidden-tokens.awk \
>>> -               "$1"
>>> +               "$1")
>>> +        if [ $? -ne 0 ] ; then
>>> +                echo $result
>>> +                res=1
>>> +        fi
>>> +
>>> +       return $res
>>>  }
>>>
>>>  number=0
>>> --
>>> 1.8.3.1
>>>
>>
>> How about just this change ?
>>
>> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
>> index ee8debe..8385384 100755
>> --- a/devtools/checkpatches.sh
>> +++ b/devtools/checkpatches.sh
>> @@ -51,7 +51,7 @@ check_forbidden_additions() { # <patch>
>>                 -v RET_ON_FAIL=1 \
>>                 -v MESSAGE='Using rte_panic/rte_exit' \
>>                 -f $(dirname $(readlink -e
>> $0))/check-forbidden-tokens.awk \
>> -               "$1"
>> +               "$1" &&
>>         # svg figures must be included with wildcard extension
>>         # because of png conversion for pdf docs
>>         awk -v FOLDERS='doc' \
>>
>
> Ah ok, nevermind, two issues.
>

Ok, second attempt, and this time tested :-)

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index ee8debe..915ef67 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -51,7 +51,7 @@ check_forbidden_additions() { # <patch>
                -v RET_ON_FAIL=1 \
                -v MESSAGE='Using rte_panic/rte_exit' \
                -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
-               "$1"
+               "$1" && \
        # svg figures must be included with wildcard extension
        # because of png conversion for pdf docs
        awk -v FOLDERS='doc' \


-- 
David Marchand