From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06A4CC433EF for ; Fri, 10 Sep 2021 07:37:09 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 9CB61610C8 for ; Fri, 10 Sep 2021 07:37:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9CB61610C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1588B40DF4; Fri, 10 Sep 2021 09:37:08 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id BF7644067E for ; Fri, 10 Sep 2021 09:37:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631259426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l/iLAphRXw2BsSfybndOz1ld6BFOZ/f6MTcFmmXTSkk=; b=gkQuR9WPF/s0FjN/e3RK3ho+jgnVgBLqE+/vQfs4Ox0Nwt0t0Ifnf9a9J3rjnOOQQ0baj4 SakINA3QMbWeIe/sUTRXa69p8TmZIQiIGZmjJOq9CMXQUuHIZXkHp7s5/0KdPM+qOPqAU4 rSYWGCYOv6hFGULLs/vhHoXf2kJuxuQ= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-247-sHVK_TUoPqWFvLa8MIVa5g-1; Fri, 10 Sep 2021 03:37:04 -0400 X-MC-Unique: sHVK_TUoPqWFvLa8MIVa5g-1 Received: by mail-lf1-f71.google.com with SMTP id k6-20020ac24566000000b003f067b5841dso427935lfm.8 for ; Fri, 10 Sep 2021 00:37:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l/iLAphRXw2BsSfybndOz1ld6BFOZ/f6MTcFmmXTSkk=; b=mzyYJhPDW4wLoONvSLCrZvQo/VwfAmffkVsj9sinQf4Sf1to/kcrQUZ/lZtRW5Rv9Z IpUrRrj/ixlyRy6w8DL76efQjCEENCUVgHKBlh7P5RTqiVyIDmOb3aLJzPJei0hj+q3w pEOS3pNDXydoRGr8Fn3rP53trYZcE4meCR91aKTy6ydtQfhZ9k9X1Ap4GGb02zpXz7sL +xiO3U928gYCaYTRX8pgdX512EhGTmcqqv+jzxV4+TQWUC0Ah/C6UHUHKRsoRslCyxTr CSbgKIufmT6aNNhdBqB+pM9UiKJalAV/r8KnRi7DWZtTreg5uA9ZMwJOvKSypWEK5FlT Q8NQ== X-Gm-Message-State: AOAM531uS2szTqUp4/77XRo+H7yTz0KyVBlbxOLre6iCoJ1QfcaCupQh hdtstD/PS+VviBpKZIj6yD2ib/j7fyREorWy25yh9fQR73zbnSC2hHjO48fxHykurDkakCMLf5R MZrj+qmEYNljVtBrcq5s= X-Received: by 2002:a2e:bd0c:: with SMTP id n12mr3029050ljq.46.1631259423353; Fri, 10 Sep 2021 00:37:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxvODFjKn8wUDWub0TKHozq3CUXwZC0SkCLXBX7pb6zSWE2Wz7g/LZyIaZdR+DO0Tmqjbk25rk5UmQ/JOtoE20= X-Received: by 2002:a2e:bd0c:: with SMTP id n12mr3029040ljq.46.1631259423172; Fri, 10 Sep 2021 00:37:03 -0700 (PDT) MIME-Version: 1.0 References: <20210909164008.343712-1-rahul.r.shah@intel.com> <55677da6-68cf-eb65-e5bb-004a4bf970c5@ashroe.eu> In-Reply-To: <55677da6-68cf-eb65-e5bb-004a4bf970c5@ashroe.eu> From: David Marchand Date: Fri, 10 Sep 2021 09:36:51 +0200 Message-ID: To: "Kinsella, Ray" , Rahul Shah Cc: dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] port: eventdev port api promoted X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 10, 2021 at 9:31 AM Kinsella, Ray wrote: > On 09/09/2021 17:40, Rahul Shah wrote: > > rte_port_eventdev_reader_ops, rte_port_eventdev_writer_nodrops_ops, > > rte_port_eventdev_writer_ops symbols promoted > > > > Signed-off-by: Rahul Shah > > --- > > lib/port/version.map | 8 +++----- > > 1 file changed, 3 insertions(+), 5 deletions(-) > > > > Hi Rahul, > > You need to strip the __rte_experimental attribute in the header file also. That's what I first thought... but those are variables, and there were not marked in the header. At least, those symbols must be alphabetically sorted in version.map. About checking for experimental mark on variables... I had a patch, but never got it in. I think we should instead (forbid such exports and|insist on) rework API / libraries that rely on public variables. -- David Marchand