From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Marchand Subject: Re: [dpdk-stable] [PATCH v3 2/2] devtools: fix result of svg include check Date: Mon, 4 Mar 2019 11:17:12 +0100 Message-ID: References: <20190214193547.30783-1-msantana@redhat.com> <20190301170806.3547-1-msantana@redhat.com> <20190301170806.3547-3-msantana@redhat.com> <86213097.jjelSHenU9@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: dpdk stable , dev@dpdk.org, Bruce Richardson , Van Haaren Harry , Rami Rosen , Thomas Monjalon To: Michael Santana Return-path: Received: from mail-ua1-f44.google.com (mail-ua1-f44.google.com [209.85.222.44]) by dpdk.org (Postfix) with ESMTP id 36DFC493D for ; Mon, 4 Mar 2019 11:17:24 +0100 (CET) Received: by mail-ua1-f44.google.com with SMTP id s15so3901262uap.6 for ; Mon, 04 Mar 2019 02:17:24 -0800 (PST) In-Reply-To: <86213097.jjelSHenU9@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Mar 1, 2019 at 6:52 PM Thomas Monjalon wrote: > 01/03/2019 18:08, Michael Santana: > > Fix trivial bug. In sh shell, 'foo = 1' is not the same as > > 'foo=1'. Using 'foo = 1' makes the shell attempt to interpret foo > > as a command, rather than a simple variable assignment. > > > > Signed-off-by: Michael Santana > > Fixes: dafc04c15174 ("devtools: fix return of forbidden addition checks") > > CC: stable@dpdk.org must be inserted below Fixes for the record in git. > > Note also that Signed-off-by must be below with a blank line. > Ah ah, great that we won't have to check this manually soon :-) Reviewed-by: David Marchand -- David Marchand