From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Marchand <david.marchand@redhat.com>
Subject: Re: [PATCH] doc: announce change of rte service API
 parameter type
Date: Fri, 1 Feb 2019 13:01:54 +0100
Message-ID: <CAJFAV8xr_pT_QLMWcsKwR0LJS4NVi5VeBCFjzb4iPRwnRu8UXw@mail.gmail.com>
References: <1548135866-98665-1-git-send-email-nikhil.rao@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Neil Horman <nhorman@tuxdriver.com>, harry.van.haaren@intel.com,
 dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>
To: Nikhil Rao <nikhil.rao@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-vk1-f194.google.com (mail-vk1-f194.google.com
 [209.85.221.194]) by dpdk.org (Postfix) with ESMTP id 52E971B4D4
 for <dev@dpdk.org>; Fri,  1 Feb 2019 13:02:06 +0100 (CET)
Received: by mail-vk1-f194.google.com with SMTP id v70so1505942vkv.7
 for <dev@dpdk.org>; Fri, 01 Feb 2019 04:02:06 -0800 (PST)
In-Reply-To: <1548135866-98665-1-git-send-email-nikhil.rao@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jan 22, 2019 at 6:46 AM Nikhil Rao <nikhil.rao@intel.com> wrote:

> rte_service_attr_get() is passed a uint32_t * to retrieve
> an attribute value, this will be changed to uin64_t * as per
> patch posted at http://patchwork.dpdk.org/patch/49968/
>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index f9a1f81..398e967 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -60,3 +60,6 @@ Deprecation Notices
>
>  * crypto/aesni_mb: the minimum supported intel-ipsec-mb library version
> will be
>    changed from 0.49.0 to 0.52.0.
> +
> +* The attr_value parameter of rte_service_attr_get() will be changed from
> +  uint32_t * to uint64_t * as the attributes are of type uint64_t.
>

Should the version in which the change is going to occur be part of the
notice ?

Apart from this, and since it fixes a problem in (mostly unused)
rte_service_attr_get() api,
Acked-by: David Marchand <david.marchand@redhat.com>

-- 
David Marchand