From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EF9DC4363A for ; Mon, 5 Oct 2020 08:12:56 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id A666F20781 for ; Mon, 5 Oct 2020 08:12:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="c7HO9a00" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A666F20781 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AC8471B708; Mon, 5 Oct 2020 10:12:52 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 287561B650 for ; Mon, 5 Oct 2020 10:12:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601885569; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I/odpbAdhNpnB+XXgQS/TjUUCw3Ckl8BJRHZ6m9fJFs=; b=c7HO9a00cvocmX5xATrB+qgGCuVI+RxKJpekbyCQOO4Y9YxMjPz4JVe+ogWLlNCyGwFbZk PYY+WPrOzB+jNolcBTMAISZaXyqx1SNsm127MfoMmDbuGaXn4HaaQS+jgyWv2l8XSbe+KS ZbxvF9zw1yoKjLaWvWyhRUR0bQIKXzA= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-92-LcyBlLi7Og2aI8YTXGNr0g-1; Mon, 05 Oct 2020 04:12:46 -0400 X-MC-Unique: LcyBlLi7Og2aI8YTXGNr0g-1 Received: by mail-vs1-f71.google.com with SMTP id d190so2644620vsc.15 for ; Mon, 05 Oct 2020 01:12:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I/odpbAdhNpnB+XXgQS/TjUUCw3Ckl8BJRHZ6m9fJFs=; b=qnudygB3wBGyCAVtvCvnx7c1dIlXHnefMwDMI6oNZHjHVLBBwERKYR0NMUeDe9//Tn 3mXIsNHRW/tQB9+xPkKx3ZGvpl8K5M/T1cg3cMjA9I5ycFqUdmYXwCy645l2628eYT7a rzk8Rva9DYLE//mrMj3s3ydEHweF4sziZcdvHmqcNly0bqm1oGUEL+a5lzi7nJAvDqL1 qrGruylTV+n2r29DqOdD4ewXSo5ykEhIDgY6sJcF3mLnQgrgPqb+tx4dN+2k508ebHgl co+YEVv51wx1rmTgL8xjYnjr1X67w594lz6IwABSuQL/qoqDy6XQKQ9FDdDEMs/ttxsi azlw== X-Gm-Message-State: AOAM531um44DKZA92IsZAR4kTg1v8/be9zr1PFZqzx4n5iKW/ybNKLpL G2WnlK8Hc2Wu/I+d0YQmf//J9xD+xhyFVWKOaOrC+F67aVIETw2MEVPNLCNOQ5UIttDQbPYOayr sSjGY0Z06jyV3xkyrJoU= X-Received: by 2002:a05:6102:5d:: with SMTP id k29mr2121887vsp.17.1601885565601; Mon, 05 Oct 2020 01:12:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyMtoTy2HdFyLAZlaVPFnP1MxIPeKI7Z3fANV878dCvy6qdWX5VoEEqjtWzJqH2/YdBBsiVx+OPo+WavtCoiI4= X-Received: by 2002:a05:6102:5d:: with SMTP id k29mr2121873vsp.17.1601885565401; Mon, 05 Oct 2020 01:12:45 -0700 (PDT) MIME-Version: 1.0 References: <20200621090800.1AE521C00D@dpdk.org> <1599822484-19100-1-git-send-email-wangyunjian@huawei.com> In-Reply-To: <1599822484-19100-1-git-send-email-wangyunjian@huawei.com> From: David Marchand Date: Mon, 5 Oct 2020 10:12:34 +0200 Message-ID: To: wangyunjian Cc: dev , "Burakov, Anatoly" , "Yigit, Ferruh" , "Lilijun (Jerry)" , xudingke , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 RESEND] vfio: fix resource leak when mapping fails X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 11, 2020 at 1:08 PM wangyunjian wrote: > > From: Yunjian Wang > > Currently, only the 'vfio_dev_fd' is closed in failure path, so > some resources are not released(such as 'vfio_group_fd'). The > rte_vfio_release_device() should be used to avoid this problem. > > Fixes: 33604c31354a ("vfio: refactor PCI BAR mapping") > Cc: stable@dpdk.org > > Signed-off-by: Yunjian Wang Reviewed-by: Anatoly Burakov Applied, thanks. -- David Marchand