From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?B?SsOpcsO0bWUgSnV0dGVhdQ==?= <jerome.jutteau@outscale.com>
Subject: Re: [PATCH 2/3] vhost: check that a device exists during
	reset_owner
Date: Mon, 19 Oct 2015 11:42:44 +0200
Message-ID: <CAJFondOqFAC=yQt-ta68cqdxiCBBvveEWLCM83ofoFQzm8_iGw@mail.gmail.com>
References: <1444986530-20893-1-git-send-email-jerome.jutteau@outscale.com>
 <1444986530-20893-3-git-send-email-jerome.jutteau@outscale.com>
 <20151019043548.GO3115@yliu-dev.sh.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com
 [209.85.214.182]) by dpdk.org (Postfix) with ESMTP id 408A45961
 for <dev@dpdk.org>; Mon, 19 Oct 2015 11:43:04 +0200 (CEST)
Received: by obbzf10 with SMTP id zf10so133949295obb.2
 for <dev@dpdk.org>; Mon, 19 Oct 2015 02:43:03 -0700 (PDT)
In-Reply-To: <20151019043548.GO3115@yliu-dev.sh.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Yuanhan,

2015-10-19 6:35 GMT+02:00 Yuanhan Liu <yuanhan.liu@linux.intel.com>:
> I would call get_device() here, which dumps an error message when
> it's NULL so that user will get noticed.
>
> Besides that, the 3 patches look good to me, and,
>
> Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>

Thanks for your review, a v2 is coming soon with get_device().

--=20
J=C3=A9r=C3=B4me