From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Subject: Re: [PATCH v2 4/4] net/ena: enable WC Date: Mon, 2 Jul 2018 08:52:46 +0200 Message-ID: References: <1530191753-18689-1-git-send-email-rk@semihalf.com> <1530191753-18689-5-git-send-email-rk@semihalf.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: dev@dpdk.org, Marcin Wojtas , "Tzalik, Guy" , "Schmeilin, Evgeny" , "Matushevsky, Alexander" , "Chauskin, Igor" , Thomas Monjalon , Ferruh Yigit To: Rafal Kozik Return-path: Received: from mail-ua0-f195.google.com (mail-ua0-f195.google.com [209.85.217.195]) by dpdk.org (Postfix) with ESMTP id 0D3694F98 for ; Mon, 2 Jul 2018 08:52:48 +0200 (CEST) Received: by mail-ua0-f195.google.com with SMTP id v15-v6so9393725ual.11 for ; Sun, 01 Jul 2018 23:52:47 -0700 (PDT) In-Reply-To: <1530191753-18689-5-git-send-email-rk@semihalf.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2018-06-28 15:15 GMT+02:00 Rafal Kozik : > > Write combining (WC) increases NIC performance by making better > utilization of PCI bus. ENA PMD may make usage of this feature. > > To enable it load igb_uio driver with wc_activate set to 1. > > Signed-off-by: Rafal Kozik > Acked-by: Bruce Richardson Acked-by: Michal Krawczyk > --- > drivers/net/ena/ena_ethdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c > index 9ae73e3..1870edf 100644 > --- a/drivers/net/ena/ena_ethdev.c > +++ b/drivers/net/ena/ena_ethdev.c > @@ -2210,7 +2210,8 @@ static int eth_ena_pci_remove(struct rte_pci_device *pci_dev) > > static struct rte_pci_driver rte_ena_pmd = { > .id_table = pci_id_ena_map, > - .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC, > + .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC | > + RTE_PCI_DRV_WC_ACTIVATE, > .probe = eth_ena_pci_probe, > .remove = eth_ena_pci_remove, > }; > -- > 2.7.4 >