From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= <mk@semihalf.com>
Subject: Re: [PATCH v3 10/27] net/ena: add lrte_timer dependency
 for linking
Date: Mon, 18 Jun 2018 08:04:43 +0200
Message-ID: <CAJMMOfOuB83Gq-LG_NgZZcDtnoefc2EwzrvCWuffggbSaW=Liw@mail.gmail.com>
References: <20180607094322.14312-1-mk@semihalf.com>
 <20180607094322.14312-10-mk@semihalf.com> <3540745.n2F2IE3GfD@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: dev@dpdk.org, Marcin Wojtas <mw@semihalf.com>,
 Guy Tzalik <gtzalik@amazon.com>,
 Evgeny Schemeilin <evgenys@amazon.com>, "Matushevsky,
 Alexander" <matua@amazon.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-ua0-f195.google.com (mail-ua0-f195.google.com
 [209.85.217.195]) by dpdk.org (Postfix) with ESMTP id 5A21A3572
 for <dev@dpdk.org>; Mon, 18 Jun 2018 08:04:44 +0200 (CEST)
Received: by mail-ua0-f195.google.com with SMTP id f30-v6so9948160uab.11
 for <dev@dpdk.org>; Sun, 17 Jun 2018 23:04:44 -0700 (PDT)
In-Reply-To: <3540745.n2F2IE3GfD@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2018-06-18 0:37 GMT+02:00 Thomas Monjalon <thomas@monjalon.net>:
> 07/06/2018 11:43, Michal Krawczyk:
>> ENA PMD is required to use librte_timer. The appropriate depndency must
>> be added ifin case the DPDK will be built as shared library.
>>
>> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
>> ---
>>  drivers/net/ena/Makefile | 1 +
>>  mk/rte.app.mk            | 1 +
>>  2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/ena/Makefile b/drivers/net/ena/Makefile
>> index 43339f3b9..ff9ce315b 100644
>> --- a/drivers/net/ena/Makefile
>> +++ b/drivers/net/ena/Makefile
>> @@ -58,5 +58,6 @@ CFLAGS += $(INCLUDES)
>>  LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
>>  LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
>>  LDLIBS += -lrte_bus_pci
>> +LDLIBS += -lrte_timer
>>
>>  include $(RTE_SDK)/mk/rte.lib.mk
>> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
>> index 1e32c83e7..c70bc254e 100644
>> --- a/mk/rte.app.mk
>> +++ b/mk/rte.app.mk
>> @@ -60,6 +60,7 @@ endif
>>
>>  _LDLIBS-y += --whole-archive
>>
>> +_LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER)          += -lrte_timer
>
> Why is it added in rte.app.mk? It is already there, few lines below.

I think that's because it wasn't present on the version I was
preparing the patch (18.02) and I didn't notice that it was added
meantime when I was rebasing this patch.

This patch is already merged to dpdk-next-net. Should I add a patch
that is reverting this change there?