Newbie question: compiling virtio-net-pmd v1.2 fails with dpdk 1.7 on a VM

Newbie question: compiling virtio-net-pmd v1.2 fails with dpdk 1.7 on a VM

[Tapio Tallgren]

Hi,

I am probably doing something obviously wrong but I cannot figure it out
right now..
I have dpdk version 1.7.1 installed and compiled (from the git repository)
and virtio-net-pmd driver version v1.2 from git.dpdk.org. When I try to
compile virtio-net-pmd with

make RTE_INCLUDE=../dpdk/build/include

I get errors like this:

virtio_user.c: In function rte_rmxbuf_alloc:
virtio_user.c:208:44: error: macro "__rte_mbuf_sanity_check" passed 3
arguments, but takes just 2

Looks like a version conflict? Dpdk 1.7 should support virtio-pmd so what
am I doing wrong?

-- 
-Tapio

Re: Newbie question: compiling virtio-net-pmd v1.2 fails with dpdk 1.7 on a VM

[Neil Horman]

On Thu, Nov 20, 2014 at 09:14:35AM +0200, Tapio Tallgren wrote:
> Hi,
> 
> I am probably doing something obviously wrong but I cannot figure it out
> right now..
> I have dpdk version 1.7.1 installed and compiled (from the git repository)
> and virtio-net-pmd driver version v1.2 from git.dpdk.org. When I try to
> compile virtio-net-pmd with
> 
> make RTE_INCLUDE=../dpdk/build/include
> 
> I get errors like this:
> 
> virtio_user.c: In function rte_rmxbuf_alloc:
> virtio_user.c:208:44: error: macro "__rte_mbuf_sanity_check" passed 3
> arguments, but takes just 2
> 
> Looks like a version conflict? Dpdk 1.7 should support virtio-pmd so what
> am I doing wrong?
> 
> -- 
> -Tapio
> 

Nothing, its a bug.  DPDK changed the API here with commit
9aaccf1abdb2894ec23870e1d2199a657f85850e but it never got changed in the
virtio_user pmd.  You need to modify the pmd like the other call sites have been
in the above commit.

This is why those external pmds need to be merged into the dpdk tree.

Neil

Re: Newbie question: compiling virtio-net-pmd v1.2 fails with dpdk 1.7 on a VM

[Thomas Monjalon]

2014-11-20 06:17, Neil Horman:
> On Thu, Nov 20, 2014 at 09:14:35AM +0200, Tapio Tallgren wrote:
> > Looks like a version conflict? Dpdk 1.7 should support virtio-pmd so what
> > am I doing wrong?
> 
> Nothing, its a bug.  DPDK changed the API here with commit
> 9aaccf1abdb2894ec23870e1d2199a657f85850e but it never got changed in the
> virtio_user pmd.  You need to modify the pmd like the other call sites have been
> in the above commit.
> 
> This is why those external pmds need to be merged into the dpdk tree.

Yes, exactly.
We'll see during 2.0 cycle how to merge them. The ideal plan is to keep only
1 implementation.

In the meantime, patches are welcome.

-- 
Thomas

Re: Newbie question: compiling virtio-net-pmd v1.2 fails with dpdk 1.7 on a VM

[Tapio Tallgren]

On Thu, Nov 20, 2014 at 1:33 PM, Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
wrote:

> 2014-11-20 06:17, Neil Horman:
> > On Thu, Nov 20, 2014 at 09:14:35AM +0200, Tapio Tallgren wrote:
> > > Looks like a version conflict? Dpdk 1.7 should support virtio-pmd so
> what
> > > am I doing wrong?
> >
> > Nothing, its a bug.  DPDK changed the API here with commit
> > 9aaccf1abdb2894ec23870e1d2199a657f85850e but it never got changed in the
> > virtio_user pmd.  You need to modify the pmd like the other call sites
> have been
> > in the above commit.
> >
> > This is why those external pmds need to be merged into the dpdk tree.
>
> Yes, exactly.
> We'll see during 2.0 cycle how to merge them. The ideal plan is to keep
> only
> 1 implementation.
>
> In the meantime, patches are welcome.
>
> --
> Thomas
>

This looks like a purely cosmetic change? So, if the code compiles, then it
will also run correctly?


-- 
-Tapio

Re: Newbie question: compiling virtio-net-pmd v1.2 fails with dpdk 1.7 on a VM

[Neil Horman]

On Thu, Nov 20, 2014 at 02:37:27PM +0200, Tapio Tallgren wrote:
> On Thu, Nov 20, 2014 at 1:33 PM, Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> wrote:
> 
> > 2014-11-20 06:17, Neil Horman:
> > > On Thu, Nov 20, 2014 at 09:14:35AM +0200, Tapio Tallgren wrote:
> > > > Looks like a version conflict? Dpdk 1.7 should support virtio-pmd so
> > what
> > > > am I doing wrong?
> > >
> > > Nothing, its a bug.  DPDK changed the API here with commit
> > > 9aaccf1abdb2894ec23870e1d2199a657f85850e but it never got changed in the
> > > virtio_user pmd.  You need to modify the pmd like the other call sites
> > have been
> > > in the above commit.
> > >
> > > This is why those external pmds need to be merged into the dpdk tree.
> >
> > Yes, exactly.
> > We'll see during 2.0 cycle how to merge them. The ideal plan is to keep
> > only
> > 1 implementation.
> >
> > In the meantime, patches are welcome.
> >
> > --
> > Thomas
> >
> 
> This looks like a purely cosmetic change? So, if the code compiles, then it
> will also run correctly?
> 
Not sure what you mean by that.  It looks to me as though the second argument
was removed.  so if you remove that, yes the code should compile and run
correctly.  But you can't just do any old thing to make the code compile (e.g
ifdef out the macro entirely, or some such), you still have to make the right
change.
Neil

> 
> -- 
> -Tapio